bug#54331: 27.2; Closing frames loaded from desktop-read

bug#54331: 27.2; Closing frames loaded from desktop-read

[Rehan Deen]

A very annoying issue with `desktop-save` and `desktop-read` that I'm encountering at the moment:

- I'm starting Emacs in `daemon-mode`, and then open a client frame via
  my WM shortcut for `emacsclient -c`. I do `desktop-read` and my saved desktop opens with the 10 or so frames I had saved.

- When I go to one of the frames with a buffer I'm no longer interested in, and do `C-x C-c`, I end up not just closing that particular frame, but **all 10 or so of the frames that were open**.

- The Emacs daemon is still running, and opening another client frame shows that the buffers haven't been killed, so nothing has been lost per se - it's just that the arrangement of all the frames I had is just ruined.

Any idea how to stop this behaviour (i.e. being able to just kill one frame from the saved configuration)? 


I have also played around with these settings

```
  (setq desktop-restore-frames t)
  (setq desktop-restore-in-current-display nil)
  (setq desktop-restore-forces-onscreen nil)

```

but the issue persists.

bug#54331: 27.2; Closing frames loaded from desktop-read

[Eli Zaretskii]

> From: Rehan Deen <rehan.deen@gmail.com>
> Date: Fri, 11 Mar 2022 00:13:23 +0530
> 
> A very annoying issue with `desktop-save` and `desktop-read` that I'm encountering at the moment:
> 
> - I'm starting Emacs in `daemon-mode`, and then open a client frame via
>   my WM shortcut for `emacsclient -c`. I do `desktop-read` and my saved desktop opens with the 10 or so frames I had saved.
> 
> - When I go to one of the frames with a buffer I'm no longer interested in, and do `C-x C-c`, I end up not just closing that particular frame, but **all 10 or so of the frames that were open**.
> 
> - The Emacs daemon is still running, and opening another client frame shows that the buffers haven't been killed, so nothing has been lost per se - it's just that the arrangement of all the frames I had is just ruined.
> 
> Any idea how to stop this behaviour (i.e. being able to just kill one frame from the saved configuration)? 

Is this really related to desktop-read?  AFAIK, "C-x C-c" deletes all
the frames displayed on the terminal, and I see the same behavior if I
start a daemon, invoke emacsclient to open a frame, and then make
several other frames from the same session.  "C-x C-c" then closes all
the frames I made.

I think this is the expected behavior.  What am I missing?

bug#54331: 27.2; Closing frames loaded from desktop-read

[Rehan Deen]

Huh, I have actually gotten used to `C-x C-c` simply closing the current
frame that I am viewing while in client-server/daemon mode. I am
prompted by the minibuffer on whether to save modified buffers --
including those not currently displayed in the frame I am closing -- but
after hitting `y` the single frame closes.

The help for `C-x C-c` says:
> C-x C-c runs the command save-buffers-kill-terminal ...
>
> Offer to save each buffer, then kill the current connection.
> If the current frame has no client, kill Emacs itself using
> ‘save-buffers-kill-emacs’.
> ...
> If emacsclient was started with a list of filenames to edit, then
> only these files will be asked to be saved.

In "standalone" mode `C-x C-c` of course kills everything (after asking
to save changes in modified buffers).

Perhaps my daemon mode behavior is not standard. I am running this in
i3wm on Manjaro Linux if that helps. How does one "usually" close a
client frame? `C-x 5 0`, mapped to some shortcut?

Eli Zaretskii writes:

>> From: Rehan Deen <rehan.deen@gmail.com>
>> Date: Fri, 11 Mar 2022 00:13:23 +0530
>> 
>> A very annoying issue with `desktop-save` and `desktop-read` that I'm encountering at the moment:
>> 
>> - I'm starting Emacs in `daemon-mode`, and then open a client frame via
>>   my WM shortcut for `emacsclient -c`. I do `desktop-read` and my saved desktop opens with the 10 or so frames I had saved.
>> 
>> - When I go to one of the frames with a buffer I'm no longer interested in, and do `C-x C-c`, I end up not just closing that particular frame, but **all 10 or so of the frames that were open**.
>> 
>> - The Emacs daemon is still running, and opening another client frame shows that the buffers haven't been killed, so nothing has been lost per se - it's just that the arrangement of all the frames I had is just ruined.
>> 
>> Any idea how to stop this behaviour (i.e. being able to just kill one frame from the saved configuration)? 
>
> Is this really related to desktop-read?  AFAIK, "C-x C-c" deletes all
> the frames displayed on the terminal, and I see the same behavior if I
> start a daemon, invoke emacsclient to open a frame, and then make
> several other frames from the same session.  "C-x C-c" then closes all
> the frames I made.
>
> I think this is the expected behavior.  What am I missing?

bug#54331: 27.2; Closing frames loaded from desktop-read

[Eli Zaretskii]

> From: Rehan Deen <rehan.deen@gmail.com>
> Cc: 54331@debbugs.gnu.org
> Date: Fri, 11 Mar 2022 12:23:29 +0530
> 
> Perhaps my daemon mode behavior is not standard. I am running this in
> i3wm on Manjaro Linux if that helps. How does one "usually" close a
> client frame? `C-x 5 0`, mapped to some shortcut?

Yes, "C-x 5 0" is the way to delete just the current frame.

bug#54331: 27.2; Closing frames loaded from desktop-read

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> Perhaps my daemon mode behavior is not standard. I am running this in
>> i3wm on Manjaro Linux if that helps. How does one "usually" close a
>> client frame? `C-x 5 0`, mapped to some shortcut?
>
> Yes, "C-x 5 0" is the way to delete just the current frame.

So I guess there's nothing to fix here?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#54331: 27.2; Closing frames loaded from desktop-read

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Rehan Deen <rehan.deen@gmail.com>,  54331@debbugs.gnu.org
> Date: Sat, 12 Mar 2022 19:00:52 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Perhaps my daemon mode behavior is not standard. I am running this in
> >> i3wm on Manjaro Linux if that helps. How does one "usually" close a
> >> client frame? `C-x 5 0`, mapped to some shortcut?
> >
> > Yes, "C-x 5 0" is the way to delete just the current frame.
> 
> So I guess there's nothing to fix here?

That's my impression, but I think we should wait for Rehan to respond.

bug#54331: 27.2; Closing frames loaded from desktop-read

[Rehan Deen]

Hi, sorry, was hoping that someone else would add their input regarding
the closing frame behavior but I am happy to close this.

If anyone else comes across this issue, I guess I would suggest
remapping `C-x 5 0` to a more convenient keybinding.

Thank you for your responses to this.

Best,

Rehan

Eli Zaretskii writes:

>> From: Lars Ingebrigtsen <larsi@gnus.org>
>> Cc: Rehan Deen <rehan.deen@gmail.com>,  54331@debbugs.gnu.org
>> Date: Sat, 12 Mar 2022 19:00:52 +0100
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> >> Perhaps my daemon mode behavior is not standard. I am running this in
>> >> i3wm on Manjaro Linux if that helps. How does one "usually" close a
>> >> client frame? `C-x 5 0`, mapped to some shortcut?
>> >
>> > Yes, "C-x 5 0" is the way to delete just the current frame.
>> 
>> So I guess there's nothing to fix here?
>
> That's my impression, but I think we should wait for Rehan to respond.

bug#54331: 27.2; Closing frames loaded from desktop-read

[Eli Zaretskii]

> From: Rehan Deen <rehan.deen@gmail.com>
> Cc: Lars Ingebrigtsen <larsi@gnus.org>, 54331@debbugs.gnu.org
> Date: Sun, 13 Mar 2022 11:25:40 +0530
> 
> Hi, sorry, was hoping that someone else would add their input regarding
> the closing frame behavior but I am happy to close this.
> 
> If anyone else comes across this issue, I guess I would suggest
> remapping `C-x 5 0` to a more convenient keybinding.

Thanks, I'm therefore closing this bug.