From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54488: 29.0.50; move-to-column/overlay-related regression in latest master, perhaps 28? Date: Tue, 22 Mar 2022 17:22:15 +0200 Message-ID: <83zglidnbs.fsf@gnu.org> References: <87bkxzdccp.fsf@gmail.com> <831qyvfpv4.fsf@gnu.org> <83fsnbfd72.fsf@gnu.org> <8735jbc6gj.fsf@gmail.com> <6095582d-7065-8089-e8c7-857f070f8ce2@yandex.ru> <87y212b9nt.fsf@gmail.com> <83a6difahu.fsf@gnu.org> <835yo6f5tu.fsf@gnu.org> <834k3qf48k.fsf@gnu.org> <87r16uavhm.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6170"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54488@debbugs.gnu.org, dgutov@yandex.ru To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 22 16:24:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWgN8-0001QJ-Az for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Mar 2022 16:24:34 +0100 Original-Received: from localhost ([::1]:53172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWgN7-0008NS-7V for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Mar 2022 11:24:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWgLe-000797-4o for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2022 11:23:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47739) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nWgLd-00064m-Ld for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2022 11:23:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nWgLd-0006ek-Ho for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2022 11:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Mar 2022 15:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54488 X-GNU-PR-Package: emacs Original-Received: via spool by 54488-submit@debbugs.gnu.org id=B54488.164796255625551 (code B ref 54488); Tue, 22 Mar 2022 15:23:01 +0000 Original-Received: (at 54488) by debbugs.gnu.org; 22 Mar 2022 15:22:36 +0000 Original-Received: from localhost ([127.0.0.1]:41636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWgLD-0006e2-MX for submit@debbugs.gnu.org; Tue, 22 Mar 2022 11:22:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWgLC-0006dq-3B for 54488@debbugs.gnu.org; Tue, 22 Mar 2022 11:22:34 -0400 Original-Received: from [2001:470:142:3::e] (port=39544 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWgL6-0005vH-Qp; Tue, 22 Mar 2022 11:22:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=BoddFOAbE9QJ1EqCBTyWJjE29xp0nrt1SSfQsoyojv8=; b=O845+gU5s/XTaYPhkd3m qesNIDWSITIYkobnlW7xhg/fz0JHido178Njjvh0ywkPeV29n9Rdcis5SNdQtLfC6bEaZBPh/uICp xQyw49gLXmzqS8jPYmhKVyAyVhsVUX+xUT4C48485JoiBGhNEwlavVa4Qmg3/jwrE1cDNZR9S4SGS dBEc4EpbZiUL2ARz3w3BySGxA2lK+nZ1twfxErnjaTSX7Wp+bzSq+4Pc39PiV0h5eZVTnHsENVsvU +mgnu9U7C/pdqV8PerQYe97L6CiQJJEJD3GBCnXwxnGJZMPDW116IK79fisYOkd1s31Apv4XEOGx1 bLsEDoMpdI+cyA==; Original-Received: from [87.69.77.57] (port=2930 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWgL6-0008WC-A1; Tue, 22 Mar 2022 11:22:28 -0400 In-Reply-To: <87r16uavhm.fsf@gmail.com> (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Tue, 22 Mar 2022 14:54:13 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228767 Archived-At: > From: João Távora > Cc: dgutov@yandex.ru, 54488@debbugs.gnu.org > Date: Tue, 22 Mar 2022 14:54:13 +0000 > > In Emacs 29, before the fix, that (point) seems to -- very surprisingly > -- return something beyond the narrowed region and so > encode-coding-string will complain with args out of range. I don't understand how (point) can return a value outside of the narrowed region, unless it runs with the narrowing temporarily disabled. Can you show me the code with that call to 'point' again? I don't think I see it in your OP. > (defun eglot-move-to-lsp-abiding-column (column) > "Move to COLUMN abiding by the LSP spec." > (save-restriction > (cl-loop > with lbp = (line-beginning-position) > initially > (narrow-to-region lbp (line-end-position)) > (move-to-column column) > for diff = (- column > (/ (- (length (encode-coding-region (or lbp (line-beginning-position)) > (point) 'utf-16 t)) > 2) > 2)) > until (zerop diff) > do (condition-case eob-err > (forward-char (/ (if (> diff 0) (1+ diff) (1- diff)) 2)) > (end-of-buffer (cl-return eob-err)))))) Why do you have to use move-to-column instead of forward-char?