From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Wed, 31 Aug 2022 14:23:14 +0300 Message-ID: <83zgfksllp.fsf@gnu.org> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> <877d2pnqup.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37958"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, ams@gnu.org, larsi@gnus.org, juri@jurta.org, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 31 13:23:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTLoq-0009hE-9C for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 13:23:40 +0200 Original-Received: from localhost ([::1]:45396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTLoo-00017V-T4 for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 07:23:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTLo4-0000Od-BP for emacs-devel@gnu.org; Wed, 31 Aug 2022 07:22:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55776) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTLo3-0000rB-Ji; Wed, 31 Aug 2022 07:22:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Qx96jjKrWK57tqOOpykj7dOkwtQSwQmVd7zgR/3WT+M=; b=Osyqd9awWt+D kUic05Dwk2RWQXR3+U1EYvCk13TiUJr90+eCbJl2z0NF4hS2Fj+0ul+o4iqYtk2UMGsdNc2KiPzjw QXafUhXMGAhxX7ZAh05PLcFuCebk0n7t4pzjuLtM8qQQPw8puQ900ATY3hGUKLq4s131yMKjEWfPI Yqp6uN3NsaMy+mNF1yjABKa2kZycBkJK329isDtFwgVPn2E2ku3VAerFeF0ciD8TORhLOTQ6VoA2u up0xLv1YMlit9Li+hjyHTGr/nGw+sZSTsOow8KwkPXswZ8eiJqtFi83XOQPuq+u+42U3k4KB83nAM dPuniQrvnFlmphfaRy1xgA==; Original-Received: from [87.69.77.57] (port=2470 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTLo2-0006nq-P7; Wed, 31 Aug 2022 07:22:51 -0400 In-Reply-To: (message from Dmitry Gutov on Wed, 31 Aug 2022 05:32:42 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294419 Archived-At: > Date: Wed, 31 Aug 2022 05:32:42 +0300 > Cc: "Alfred M. Szmidt" , eliz@gnu.org, larsi@gnus.org, > juri@jurta.org, emacs-devel@gnu.org > From: Dmitry Gutov > > >> I can look into adapting this approach for other VCS if nobody beats > >> me to it. As long as we fundamentally agree on the behavior. > > Thank you. > > This seems to work. Thanks. > + (dolist (f files) > + (copy-file (expand-file-name f root) > + (expand-file-name f tmpdir))) What if f includes leading directories, as in "lisp/foo.el"? If tmpdir doesn't have a subdirectory 'lisp', the copy-file will fail, no? > + (unwind-protect > + (let ((default-directory root)) > + (dolist (f files) > + (with-current-buffer (get-file-buffer f) ^^^^^^^^^^^^^^^^^^^ This assumes that all the files are visited in buffers? Is that guaranteed?