From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58283: 29.0.50; calendar-goto-day-of-year => wrong-type-argument numberp Date: Tue, 04 Oct 2022 15:14:27 +0300 Message-ID: <83zgebvl98.fsf@gnu.org> References: <87r0zow7ty.fsf@codeisgreat.org> <875yh0t1cw.fsf@gmx.net> <834jwjx641.fsf@gnu.org> <87wn9fsxz9.fsf@rub.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38867"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pankaj@codeisgreat.org, 58283-done@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 04 14:15:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofgpO-0009qF-0L for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Oct 2022 14:15:14 +0200 Original-Received: from localhost ([::1]:60530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofgpN-000365-3k for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Oct 2022 08:15:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofgpD-000358-8q for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 08:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53715) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ofgpC-0003N9-EL for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 08:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ofgpB-0006VY-W9 for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 08:15:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Oct 2022 12:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 58283 X-GNU-PR-Package: emacs Mail-Followup-To: 58283@debbugs.gnu.org, eliz@gnu.org, pankaj@codeisgreat.org Original-Received: via spool by 58283-done@debbugs.gnu.org id=D58283.166488568324968 (code D ref 58283); Tue, 04 Oct 2022 12:15:01 +0000 Original-Received: (at 58283-done) by debbugs.gnu.org; 4 Oct 2022 12:14:43 +0000 Original-Received: from localhost ([127.0.0.1]:52792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofgos-0006Ue-Jh for submit@debbugs.gnu.org; Tue, 04 Oct 2022 08:14:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofgon-0006UO-Pe for 58283-done@debbugs.gnu.org; Tue, 04 Oct 2022 08:14:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37164) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofgoi-0003If-4R; Tue, 04 Oct 2022 08:14:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OJMu5L8XNTmy9pG+JBcv/P+v+Y2QiiXMbFlNHB5Pjtg=; b=pv2iT7c9BFYc o9AH9cEFf5spU8EYuOsPpLOxP1+DIFkt4bJQbENPYn9u/od3s++6T8srdtGXWfkhyxDK/pvQCofvH /Nmy2J94BVvuX629sk24vIgaRxbz4NsrbxMCKzrXHwtOHOoAeNSQiofQ+Avp6R0feXyfa9NI5liu8 c9IQYMkUli5XFhqv5ZUaYRFWkzxEhIY7NKcn7IyF6wzNJnzueD4AMUDXZu+u4KfRvgvVnc+nMKzra tZXy6MGZ8b3h7nlbApx6Yfnmu6VyN7f7nmjG628fglDEnIzeph8yD02EfAUohoJmG9y1b1sBzijEP IkkPEE5haXKcTFUkLbL43A==; Original-Received: from [87.69.77.57] (port=3180 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofgoh-0006lw-Jg; Tue, 04 Oct 2022 08:14:31 -0400 In-Reply-To: <87wn9fsxz9.fsf@rub.de> (message from Stephen Berman on Tue, 04 Oct 2022 12:07:54 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244416 Archived-At: > From: Stephen Berman > Cc: pankaj@codeisgreat.org, 58283@debbugs.gnu.org > Date: Tue, 04 Oct 2022 12:07:54 +0200 > > On Tue, 04 Oct 2022 12:58:38 +0300 Eli Zaretskii wrote: > > >> Cc: 58283@debbugs.gnu.org > >> From: Stephen Berman > >> Date: Tue, 04 Oct 2022 10:54:55 +0200 > >> > >> On Tue, 04 Oct 2022 09:36:49 +0530 Pankaj Jangid wrote: > >> > >> > Steps: > >> > > >> > 1. emacs -Q > >> > 2. M-x calendar RET g D RET RET > >> > > >> > => > >> > > >> > Debugger entered--Lisp error: (wrong-type-argument numberp nil) > >> > abs(nil) > >> > #f(compiled-function (x) #)(nil) > >> > calendar-read-sexp("Day number (+/- 1-%d)" #f(compiled-function (x) > >> > #) nil 365) > >> > byte-code("\300\301\302\303 > >> > \304\18\262\1#\211\211\305W\203\30\0\306\1!S\262\1\211\307\246\305U\205.\0\211\310\246\305U?\206.\0\211\311\246\305U\262\1\2037..." > >> > [calendar-read-sexp "Year (>0)" #f(compiled-function (x) # >> > -0x1433d194a6bf3cb2>) calendar-current-date 2 0 abs 4 100 400 366 365 "Day > >> > number (+/- 1-%d)" make-closure #f(compiled-function (x) # >> > 0x79fd4d90378a2b>) nil] 7) > >> > call-interactively(calendar-goto-day-of-year nil nil) > >> > command-execute(calendar-goto-day-of-year) > >> > >> The value of the `default' argument in the calendar-read-sexp call here > >> has to be a number instead of nil. > >> But what number? 1, 365, (random 365), ...? > > > > I decided that today's day number is a good default. > > Seems reasonable (though displaying that default value in the prompt > ("Day number (+/- 1-365) (default 277): ") may make innocent users of > the command wonder about it; though maybe that's not so bad...). Let's see if users start complaining. My guess is that no one ever used the default anyway, until now. > > Please see if the latest master solves this, and thanks. > > Works for me. Thanks, closing.