From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58547: 29.0.50; [PATCH] Fix one internal naming Date: Sat, 15 Oct 2022 17:28:10 +0300 Message-ID: <83zgdx5fgl.fsf@gnu.org> References: <878rlhtfew.fsf@elite.giraud> <8335bp6wxo.fsf@gnu.org> <874jw5tdg4.fsf@elite.giraud> <831qr96vnj.fsf@gnu.org> <87lephp4mf.fsf@elite.giraud> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27107"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58547@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 15 16:29:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojiA2-0006tL-Kw for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Oct 2022 16:29:10 +0200 Original-Received: from localhost ([::1]:35836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojiA0-00075y-5c for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Oct 2022 10:29:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oji9u-00075C-UR for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 10:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43293) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oji9u-0004hH-ME for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 10:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oji9u-0000WZ-Br for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 10:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Oct 2022 14:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58547-submit@debbugs.gnu.org id=B58547.16658441041962 (code B ref 58547); Sat, 15 Oct 2022 14:29:02 +0000 Original-Received: (at 58547) by debbugs.gnu.org; 15 Oct 2022 14:28:24 +0000 Original-Received: from localhost ([127.0.0.1]:42370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oji9H-0000VZ-RY for submit@debbugs.gnu.org; Sat, 15 Oct 2022 10:28:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oji9E-0000VM-8C for 58547@debbugs.gnu.org; Sat, 15 Oct 2022 10:28:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56432) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oji98-0004eO-Hg; Sat, 15 Oct 2022 10:28:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=k4BWZMmkvf9TRmAU3/7GZMoz3uS6b+a2vLXm+VPbqMg=; b=T+4P3nJOOMAR VbEZmoK19Oik5rQjNK1jYjEX2tYHfKonpsMz+BV1kCKDO8ZwjvuonzjxfgsXIK7WY29OscOKr7EiV xUcKETtrg2YmHiUKgRQ6mHvQX5ixTnCkwPXNXtbAyompGeZzHcjUehsmZd1q6zO4M9+h/k4knjJY7 ZrzhYi7ND74UYWI1Z7Uv/aJ7FHVnnQelv1l/s3BwGRZ6wlMIKwpMkidVj7prnJrJQOR6d37i1Xdxt Njc5XxgGxodeZUdTXt9FziaF6NHZP6LRFnBEnofYA1tDoqdhmpsqnayrVPMUP7YzEmfIG9HHLS/Gw GC+l/x3FtQbT8Gowm2WX1g==; Original-Received: from [87.69.77.57] (port=3262 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oji98-0000lM-0f; Sat, 15 Oct 2022 10:28:14 -0400 In-Reply-To: <87lephp4mf.fsf@elite.giraud> (message from Manuel Giraud on Sat, 15 Oct 2022 16:02:00 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245561 Archived-At: > From: Manuel Giraud > Cc: 58547@debbugs.gnu.org > Date: Sat, 15 Oct 2022 16:02:00 +0200 > > Eli Zaretskii writes: > > > Right. But still: I'm not against renaming them, if we find a better, > > more general name. > > Why not. In fact (and FTR), I wanted to rename this function because it > is strangely similar to the function `x_menu_bar_height' that I have > introduced in bug#58515. So maybe, one day, the menu_line could become > one those "mode lines", WDYT? That's possible, yes. The existing ones are similar in that they use mode/header/tab-line-format, and that one supports certain special constructs that are implemented in the subroutines called by mode_line_height. So if the menu-bar will come close to supporting the same features, it would make sense to try to add it to the group, indeed.