From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: 58547@debbugs.gnu.org
Subject: bug#58547: 29.0.50; [PATCH] Fix one internal naming
Date: Sat, 15 Oct 2022 17:28:10 +0300 [thread overview]
Message-ID: <83zgdx5fgl.fsf@gnu.org> (raw)
In-Reply-To: <87lephp4mf.fsf@elite.giraud> (message from Manuel Giraud on Sat, 15 Oct 2022 16:02:00 +0200)
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 58547@debbugs.gnu.org
> Date: Sat, 15 Oct 2022 16:02:00 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Right. But still: I'm not against renaming them, if we find a better,
> > more general name.
>
> Why not. In fact (and FTR), I wanted to rename this function because it
> is strangely similar to the function `x_menu_bar_height' that I have
> introduced in bug#58515. So maybe, one day, the menu_line could become
> one those "mode lines", WDYT?
That's possible, yes.
The existing ones are similar in that they use
mode/header/tab-line-format, and that one supports certain special
constructs that are implemented in the subroutines called by
mode_line_height. So if the menu-bar will come close to supporting
the same features, it would make sense to try to add it to the group,
indeed.
next prev parent reply other threads:[~2022-10-15 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 12:55 bug#58547: 29.0.50; [PATCH] Fix one internal naming Manuel Giraud
2022-10-15 13:25 ` Eli Zaretskii
2022-10-15 13:37 ` Manuel Giraud
2022-10-15 13:53 ` Eli Zaretskii
2022-10-15 14:02 ` Manuel Giraud
2022-10-15 14:28 ` Eli Zaretskii [this message]
2022-11-11 13:28 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zgdx5fgl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=58547@debbugs.gnu.org \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.