From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed) Date: Sun, 04 Dec 2022 14:53:40 +0200 Message-ID: <83zgc39vor.fsf@gnu.org> References: <835yerd5gb.fsf@gnu.org> <87ilirr0uq.fsf@yahoo.com> <83ilirbh68.fsf@gnu.org> <87a643qt09.fsf@yahoo.com> <838rjnbbqc.fsf@gnu.org> <0137C1CC-0AEC-4790-85E6-D1AD987A63E1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14297"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, gerd.moellmann@gmail.com, 59794@debbugs.gnu.org To: Kai Ma Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 04 13:55:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1oWa-0003YF-0n for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Dec 2022 13:55:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1oWN-0003pg-OS; Sun, 04 Dec 2022 07:55:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1oWM-0003pD-3N for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 07:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1oWL-0003f0-Px for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 07:55:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1oWL-0007jG-LP for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 07:55:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Dec 2022 12:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59794 X-GNU-PR-Package: emacs Original-Received: via spool by 59794-submit@debbugs.gnu.org id=B59794.167015844829630 (code B ref 59794); Sun, 04 Dec 2022 12:55:01 +0000 Original-Received: (at 59794) by debbugs.gnu.org; 4 Dec 2022 12:54:08 +0000 Original-Received: from localhost ([127.0.0.1]:57478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1oVU-0007hq-1F for submit@debbugs.gnu.org; Sun, 04 Dec 2022 07:54:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1oVS-0007hS-3u for 59794@debbugs.gnu.org; Sun, 04 Dec 2022 07:54:06 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1oVM-0003EQ-PI; Sun, 04 Dec 2022 07:54:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=UT5tMetj6iJgNIz979b4A33DSSSctt2DrVRDaS+7ZyE=; b=i/yFZAqdQhXyeH94RjYN jWH9ac8CVQBrPxiSsqiVdREqOR/Wyt6u8TsxuY9bRwImOzarzIA4GIVhvxTyJ5jW3AZmIscT6RP8N CTkooA8WJMGFvJAUe7jX799A4IuUON3cTpOBew6hvjVvqftAFrdJ1XaWzKWlWcNRGmXuQGP4DXBbW 3FRep3tdM60QrMgbp4p/+4V1rndjNyIUdSo8fL7g0mGYrwfLB3dM1HrvZVC9/XTEm+c/YV/opW6v1 50gq59jT+p+5oyTLLFJUlZOhXDR06NqtE61y8/7gmNkkbCY1M7R84aMxBHiMA4ub0HyZ1W/CREpsu 7Z7PUSs7FibXqQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1oVM-0007mh-8T; Sun, 04 Dec 2022 07:54:00 -0500 In-Reply-To: <0137C1CC-0AEC-4790-85E6-D1AD987A63E1@gmail.com> (message from Kai Ma on Sun, 4 Dec 2022 20:45:12 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249934 Archived-At: > From: Kai Ma > Date: Sun, 4 Dec 2022 20:45:12 +0800 > Cc: Po Lu , > Gerd Möllmann , > 59794@debbugs.gnu.org > > > On Dec 4, 2022, at 20:21, Eli Zaretskii wrote: > >> Thanks. I'm fine with installing this on the release branch, but the > >> comment should be modified to say: > >> > >> [resetCursorRects:] can be called from the event loop after the frame > >> is deleted. When this happens, emacsframe is NULL. This means there > >> is an underlying leak of the EmacsView object! > >> > >> also, perhaps it should be omitted on master, at least until before > >> Emacs 30 is released, to motivate other (hopefully more knowledgeable) > >> people to provide the necessary information to fix it. > > > > Will do, thanks. > > > I took a few liberties here. Attached is the revised patch. Thanks, I already pushed the change.