From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: thievol@posteo.net, 58919@debbugs.gnu.org, eggert@cs.ucla.edu
Subject: bug#58919: 28.2; dired-copy-file-recursive fails to overwrite directory
Date: Sun, 11 Dec 2022 12:46:22 +0200 [thread overview]
Message-ID: <83zgbutdz5.fsf@gnu.org> (raw)
In-Reply-To: <87k04ebhvn.fsf@gmx.de> (message from Michael Albinus on Tue, 01 Nov 2022 20:21:32 +0100)
Ping!
Paul, did you have an opportunity to come up with the patch you
mentioned in this discussion? I'd like to solve this bug for Emacs
29, please.
> From: Michael Albinus <michael.albinus@gmx.de>
> Date: Tue, 01 Nov 2022 20:21:32 +0100
> Cc: Thierry Volpiatto <thievol@posteo.net>, 58919@debbugs.gnu.org,
> Eli Zaretskii <eliz@gnu.org>
>
> Paul Eggert <eggert@cs.ucla.edu> writes:
>
> Hi Paul,
>
> > The simplest fix I can see is to enhance make-directory so that it
> > returns t if the directory already existed and PARENTS was given, nil
> > on any other successful return. This would require changes to Tramp to
> > avoid races there. I plan to post a proposed patch for comment.
>
> To make it more fun, there are several Tramp implementations of that
> function, and also other ones. Xref, running in the lisp/ tree for
> "defun.*make-directory", returns
>
> --8<---------------cut here---------------start------------->8---
> lisp/dired.el
> 1911: (defun dired--make-directory-clickable ()
> lisp/files.el
> 6203: (defun make-directory (dir &optional parents)
> lisp/gnus/gnus-group.el
> 3120: (defun gnus-group-make-directory-group (dir)
> lisp/gnus/gnus-util.el
> 726: (defun gnus-make-directory (directory)
> lisp/htmlfontify.el
> 1844: (defun hfy-make-directory (dir)
> lisp/ido.el
> 2994: (defun ido-make-directory (&optional dir)
> lisp/net/ange-ftp.el
> 4125: (defun ange-ftp-make-directory (dir &optional parents)
> 4530: (defun ange-ftp-real-make-directory (&rest args)
> lisp/net/tramp-adb.el
> 411: (defun tramp-adb-handle-make-directory (dir &optional parents)
> lisp/net/tramp-crypt.el
> 800: (defun tramp-crypt-handle-make-directory (dir &optional parents)
> lisp/net/tramp-fuse.el
> 128: (defun tramp-fuse-handle-make-directory (dir &optional parents)
> lisp/net/tramp-gvfs.el
> 1560: (defun tramp-gvfs-handle-make-directory (dir &optional parents)
> lisp/net/tramp-sh.el
> 2559: (defun tramp-sh-handle-make-directory (dir &optional parents)
> lisp/net/tramp-smb.el
> 1172: (defun tramp-smb-handle-make-directory (dir &optional parents)
> 1192: (defun tramp-smb-handle-make-directory-internal (directory)
> lisp/net/tramp-sudoedit.el
> 626: (defun tramp-sudoedit-handle-make-directory (dir &optional parents)
> lisp/obsolete/autoload.el
> 725: (defun make-directory-autoloads (dir output-file)
> lisp/url/url-dav.el
> 761: (defun url-dav-make-directory (url &optional _parents)
> --8<---------------cut here---------------end--------------->8---
>
> Best regards, Michael.
>
>
>
>
next prev parent reply other threads:[~2022-12-11 10:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 8:54 bug#58919: 28.2; dired-copy-file-recursive fails to overwrite directory Thierry Volpiatto
2022-10-31 13:01 ` Eli Zaretskii
2022-11-01 17:34 ` Thierry Volpiatto
2022-11-01 18:04 ` Paul Eggert
2022-11-01 18:09 ` Eli Zaretskii
2022-11-01 19:21 ` Michael Albinus
2022-12-11 10:46 ` Eli Zaretskii [this message]
2022-12-16 23:22 ` Paul Eggert
2022-12-17 8:04 ` Eli Zaretskii
2022-12-17 9:52 ` Michael Albinus
2022-12-17 10:40 ` Eli Zaretskii
2022-12-17 22:40 ` Paul Eggert
2022-12-18 19:35 ` Michael Albinus
2022-12-18 20:54 ` Paul Eggert
2022-12-23 10:26 ` Michael Albinus
2022-12-24 9:11 ` Paul Eggert
2022-12-24 10:13 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zgbutdz5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=58919@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=michael.albinus@gmx.de \
--cc=thievol@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.