From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: master ef14acf: Make nnml handle invalid non-ASCII headers more consistently Date: Mon, 19 Dec 2022 19:07:57 +0200 Message-ID: <83zgbjcoeq.fsf@gnu.org> References: <20210122180801.14756.84264@vcs0.savannah.gnu.org> <20210122180802.F0A1E20A10@vcs0.savannah.gnu.org> <874jtvq8c2.fsf@oldenburg.str.redhat.com> <83k02qiicb.fsf@gnu.org> <87bko26ptd.fsf@oldenburg.str.redhat.com> <83r0wygh9b.fsf@gnu.org> <87k02nze8a.fsf@oldenburg.str.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20881"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, eric@ericabrahamsen.net, emacs-devel@gnu.org, ding@gnus.org To: Florian Weimer Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 19 18:08:28 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7Jcp-0005Bh-4V for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Dec 2022 18:08:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7JcC-0000w0-Us; Mon, 19 Dec 2022 12:07:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7JcB-0000vr-OQ for emacs-devel@gnu.org; Mon, 19 Dec 2022 12:07:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7JcB-00089c-Ax; Mon, 19 Dec 2022 12:07:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=a3Mvu12p/3lZldZHKdTcWPsEQoJIdLhVmXgmk+lTEsQ=; b=JcIJOPo8eIerPN+B1k5l IKZmwFQeYAJr8DBO6xILY/fXC/c5QkhkZt9U0359TL7V101D/54ikXzI3pUpmu1LwcURnuavUIOaN 3KKta6S29Lt+9J3YjUp39g7fu4Y6egw3iX/7sW+eUNGEdCS5Ef23FwCcrPSzJqu9/7Yw8pCDSYlER MzDLx6KpaUGBM3YcZ9PsmGGnUppgjqt1ZEXNSyN2iPFlJnkA1CeLfQxPBSN85vrsPGvUX9H3Moi0V V8TEgNMBFMJPsDj1b5+U8hzZX3u7gKvUqGamGqUWhx9HhBlQs+4v8Z2/ifRhXrCPVJhYrshxNtZq7 KV4d6otY5RYGuA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7JcA-0006jK-No; Mon, 19 Dec 2022 12:07:47 -0500 In-Reply-To: <87k02nze8a.fsf@oldenburg.str.redhat.com> (message from Florian Weimer on Mon, 19 Dec 2022 14:59:17 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301660 gmane.emacs.gnus.general:91036 Archived-At: > From: Florian Weimer > Cc: larsi@gnus.org, eric@ericabrahamsen.net, emacs-devel@gnu.org, > ding@gnus.org > Date: Mon, 19 Dec 2022 14:59:17 +0100 > > > I'm not sure this is related. I was talking about the missing SPC > > character before the parentheses. But I know very little about this > > stuff, so maybe I'm just misunderstanding you. > > I was responding to “this From header is invalid”. I'm not sure if the > original message is actually malformed. Ah, okay. I'm not sure, either, although I don't think I've ever seen such addresses. But I'm no expert. Maybe rfc2047.el needs to be more tolerant and less dependent on whitespace; I'll leave that to experts. But even if there's nothing wrong with this particular header, I think you will agree that signaling and error and thus failing the entire storage of the message is not TRT, especially since the change which causes this was done for basically aesthetic reasons. Falling back to previous behavior in these cases is better, I think. > As I expected, I could reproduce the issue with new mail. I'm happy to > report that replacing nnml--encode-headers with your new version fixes > the issue. Thanks, so I've now installed this on the emacs-29 branch, for the upcoming Emacs 29.1. > Going back to older mail, I see that previously the From: header was > written in encoded form to .overview (slightly wrapped to avoid SMTP > issues): > > 8523 Re: [PATCH 1/7] Rename 'hello2.spec.' -> 'hello2.spec' 'hello3.spec.' -> 'hello3.spec' =?utf-8?b?572X5YuH5YiaKFlvbmdnYW5nIEx1bykgdmlhIEVsZnV0aWxzLWRldmVs?= Thu, 24 Nov 2022 16:27:56 +0800 > <20220920084307.1696-1-luoyonggang@gmail.com> <20220920084307.1696-2-luoyonggang@gmail.com> <20221019194930.GC24703@redhat.com> <3bf19d05c8976411432709fae1cc2bcc2d21d700.camel@klomp.org> > <586fbfd512763e539f0d06e8ffa308da34be5368.camel@wildebeest.org> 705 32 Xref: oldenburg.str.redhat.com lists.sourceware.elfutils-devel:8523 Cc: "Frank Ch. Eigler" , elfutils-devel@sourceware.org To: Mark Wielaard > > Now it uses unencoded form: > > 8762 Re: [PATCH v2 13/16] lib: isatty is not available on windows 罗勇刚(Yonggang Luo) via Elfutils-devel Mon, 19 Dec 2022 20:32:48 +0800 <20221217165213.152-1-luoyonggang@gmail.com> > <20221217165213.152-14-luoyonggang@gmail.com> 1074 43 Xref: oldenburg.str.redhat.com lists.sourceware.elfutils-devel:8762 To: elfutils-devel@sourceware.org Is that a problem? I think this was part of the reason for that change in nnml.el. > I assume that there is some protection in place that tabs are not > possible here? Tabs where, and what kind of protection are we talking about? Again, I'm not an expert on this and don't use Gnus, so apologies for possibly dumb questions.