From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60399: 30.0.50; Usage of `isearch-open-invisible-temporary' is not documented Date: Mon, 02 Jan 2023 14:29:29 +0200 Message-ID: <83zgb115na.fsf@gnu.org> References: <87tu1ev7uu.fsf@localhost> <865yduf73m.fsf@mail.linkov.net> <87mt73afow.fsf@localhost> <83zgb239rv.fsf@gnu.org> <87edse8vu1.fsf@localhost> <83wn6634gb.fsf@gnu.org> <87bkni8lk3.fsf@localhost> <83tu1a2wbv.fsf@gnu.org> <875ydp5n6g.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8213"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60399-done@debbugs.gnu.org, juri@linkov.net To: Ihor Radchenko , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 02 13:30:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCJxK-0001mQ-5K for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Jan 2023 13:30:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCJx6-00061Q-Nx; Mon, 02 Jan 2023 07:30:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCJx4-00060s-Eg for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 07:30:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pCJx4-0001lG-61 for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 07:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pCJx3-00057k-Qc for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 07:30:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Jan 2023 12:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60399 X-GNU-PR-Package: emacs Original-Received: via spool by 60399-done@debbugs.gnu.org id=D60399.167266258019640 (code D ref 60399); Mon, 02 Jan 2023 12:30:01 +0000 Original-Received: (at 60399-done) by debbugs.gnu.org; 2 Jan 2023 12:29:40 +0000 Original-Received: from localhost ([127.0.0.1]:42658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCJwh-00056h-QT for submit@debbugs.gnu.org; Mon, 02 Jan 2023 07:29:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCJwf-00056S-7o for 60399-done@debbugs.gnu.org; Mon, 02 Jan 2023 07:29:37 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCJwZ-0001k2-6T; Mon, 02 Jan 2023 07:29:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tPf80LWZG7d/4dcWt1W9cT+rSNRydmiJvEPZ6/ZVDQs=; b=lTIV/aCqMOqU lNQVNDQZPRacN9Adgxqpgg2lBVgkYZYM2NKjuy/O3jaqzNxZagwKXp0czIUy2KDc9t2aAxiNeisTf OFTxh+gVM5yanosjPwcQ10zQeMzIfx6O1zXOw1sBfhw4tk4UDTCxsvFrjuH4uwkGUPv4nLmyuVvuR qLR1DjbkcY8J2B+pmYR9mHmPJrZZaK/aB8WrpTZcvUR+eFatpPbe+dJNkviHxllu3qZTzwXOMD1tY fJFNsZupnP5T5SPqKaHN5VnbkWe41Y8kqGAhpzUsjMEF681qGYkXwqjogA+5ReNrbh1ginmm8d9gu 9pmOTkDOdmx6bo0Qom4qtg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCJwQ-00077n-Ma; Mon, 02 Jan 2023 07:29:30 -0500 In-Reply-To: <875ydp5n6g.fsf@localhost> (message from Ihor Radchenko on Mon, 02 Jan 2023 08:57:11 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252330 Archived-At: > From: Ihor Radchenko > Cc: juri@linkov.net, 60399-done@debbugs.gnu.org > Date: Mon, 02 Jan 2023 08:57:11 +0000 > > Eli Zaretskii writes: > > > Thanks, this background was indeed missing. However, even after > > reading it, I still don't understand how come you need or want to > > delete these overlays -- aren't they needed to hide the text to begin > > with? > > > > Or IOW, if you are deleting and recreating the overlays, why do you > > need to use this isearch feature at all? just delete them when you > > want to show the text, and reapply them later when you want the text > > hidden again. > > This is pretty much what is being done: I try to hook into isearch code > to (1) when isearch is about to display the match, I save the old > overlays and re-arrange them to display the match as needed; (2) when > isearch moves to the next match, I restore the old overlays. > > However, because isearch expects the overlays to exist even upon > revealing the isearch match, I cannot achieve what I want. Even though > my code would work fine, isearch itself errs in > `isearch-close-unnecessary-overlays'/`isearch-open-necessary-overlays' > where it does additional checks involving `overlay-start' and > `overlay-end' that must be non-nil. I guess it's a bug in open/close-unnecessary-overlays, then? I'm not really sure I understand their role here. Juri, Stefan, can you help out?