From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60999: 30.0.50; [PATCH] Add support for negative indices and index ranges in Eshell Date: Sun, 22 Jan 2023 08:29:20 +0200 Message-ID: <83zgabjd4v.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9062"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60999@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 22 07:30:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJTs5-0002CD-EQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Jan 2023 07:30:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJTrl-0006bi-UP; Sun, 22 Jan 2023 01:30:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJTrf-0006bA-Tf for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2023 01:30:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJTrf-0004gU-K5 for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2023 01:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJTrf-0000k8-28 for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2023 01:30:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Jan 2023 06:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60999 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60999-submit@debbugs.gnu.org id=B60999.16743689642773 (code B ref 60999); Sun, 22 Jan 2023 06:30:02 +0000 Original-Received: (at 60999) by debbugs.gnu.org; 22 Jan 2023 06:29:24 +0000 Original-Received: from localhost ([127.0.0.1]:50485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJTr1-0000if-Po for submit@debbugs.gnu.org; Sun, 22 Jan 2023 01:29:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJTr0-0000iS-2N for 60999@debbugs.gnu.org; Sun, 22 Jan 2023 01:29:22 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJTqu-0004ae-PG; Sun, 22 Jan 2023 01:29:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=32Ty2dy6rtSE5maJdE65nqfncwTQZMrBPFpXfDiBpaY=; b=LZwiHX72ZtS9 jgLeOraIN5DMtPhU+gEBYIhjzpKy/U3yMAo2G/VNih0LQGC2S8eYQVVIdpGJoNftZjNLuXNWyVntn aaaT/3lRfAcAfTtgNoOUjet/EbpzS68rvcHeeWY9t4IbafhHvF0liiGy2kG/xddqm7dZ2LNu5sli6 kihJsSxNunypqlrfrwCUpTRDx4VfTspn4PuK5g4siTHq2LSC/lN4Gy/mKzoDo/KKN4m5jzM6VG1yE t3nRr7UTo05gOp0+oaH7LQJmqAroBYv1Z04pj1+dQTf4AkM+tQ+mZVUQAIbnf5PCQVjTxiSvYwNOl sHG7FKP6p+tGCRX5j4bM/g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJTqu-0005uo-1X; Sun, 22 Jan 2023 01:29:16 -0500 In-Reply-To: (message from Jim Porter on Sat, 21 Jan 2023 19:47:47 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253906 Archived-At: > Date: Sat, 21 Jan 2023 19:47:47 -0800 > From: Jim Porter > > Attached is a patch to do this. For the second suggestion, I took some > liberties and added range syntax, so that "$x[2..5]" returns elements 2, > 3, and 4 (zero-indexed) of x. > > I have just one question though: this implementation treats ranges as > half-open, i.e. "M..N" is [M, N). I think that's the best way of doing > things (and it matches how 'seq-subseq' works). However, "M..N" is the > Bash syntax, which uses a closed range, [M, N]. Maybe this would be too > confusing for users? I'm open to using other tokens aside from ".." if > that would help. Maybe "M:N" would work? That's the Python syntax, which > behaves the same way as this patch. Any thoughts? I think compatibility to other shells is an advantage. > +(defcustom eshell-integer-regexp (rx (? "-") (+ digit)) > + "Regular expression used to match integer arguments." > + :type 'regexp) Why is this a defcustom? what alternative could a user possibly want? Thanks.