From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60953: The :match predicate with large regexp in tree-sitter font-lock seems inefficient Date: Wed, 01 Feb 2023 15:10:38 +0200 Message-ID: <83zg9xzg35.fsf@gnu.org> References: <7624dddc-4600-9a03-ac8b-d3c9e0ab618c@yandex.ru> <83wn5ag4nc.fsf@gnu.org> <01b5d074-fb12-6b1f-cbfb-5e759833b854@yandex.ru> <838rhpg57n.fsf@gnu.org> <5026D975-983F-4D18-8690-BE139C92825D@gmail.com> <83pmb1emxi.fsf@gnu.org> <6f318afc-ca71-8b7e-c822-52e6635b5718@yandex.ru> <83sffxcfxw.fsf@gnu.org> <83pmb1cbg5.fsf@gnu.org> <2da844d3-ea31-289e-2821-aa174e365ffd@yandex.ru> <6784f9e7-844b-374d-2a1e-8a61cebe0d7e@yandex.ru> <83zga03yne.fsf@gnu.org> <373a575f-c683-1581-c3e6-502e9897fb04@yandex.ru> <83mt603vrc.fsf@gnu.org> <83e58a1b-2e4a-356a-36d8-c756ff105b62@yandex.ru> <83bkmf52va.fsf@gnu.org> <33cad4c1-4af5-37bb-05bc-79a4d9c1a700@yandex.ru> <83wn533lut.fsf@gnu.org> <19892f55-498e-1109-2229-2ddd984849a4@yandex.ru> <83tu073ksp.fsf@gnu.org> <83sffr2xq2.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20679"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 60953@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 01 14:11:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNCtk-0005Dj-Bl for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Feb 2023 14:11:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNCtF-0001ek-20; Wed, 01 Feb 2023 08:11:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNCtD-0001cW-0S for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2023 08:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNCtC-0001m1-OA for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2023 08:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNCtC-0005k7-64 for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2023 08:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Feb 2023 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60953 X-GNU-PR-Package: emacs Original-Received: via spool by 60953-submit@debbugs.gnu.org id=B60953.167525705322048 (code B ref 60953); Wed, 01 Feb 2023 13:11:02 +0000 Original-Received: (at 60953) by debbugs.gnu.org; 1 Feb 2023 13:10:53 +0000 Original-Received: from localhost ([127.0.0.1]:56823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNCt2-0005jX-RA for submit@debbugs.gnu.org; Wed, 01 Feb 2023 08:10:53 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNCsx-0005jC-N0 for 60953@debbugs.gnu.org; Wed, 01 Feb 2023 08:10:50 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNCsr-0001V8-3k; Wed, 01 Feb 2023 08:10:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PpOa9Ez+uUuDLqDUYK2sOaDYnxAwdtCrC1nsTlmlLQU=; b=KgeRr6vcCl7b LsCOo7UqaLn0oMT2vy501lEENa8njVzEgsJTAH24DAB8TAAdAst5V2mQz4lHPBb8flb94n6Cn1w/x 50j3DappiaKQ4+YWSZtawqdZxekMmxokvdPBuukqq2W4S/i4BxRD+8nQO9qMkUlhNeqAvPLBpVYi7 4wt8DcOnG/EZhvqVXaHE+nnzX1CvuUZ3juJRUTZLF2qlUQZqlk0OmqUCr4zojYD2h1ESorU2Q3Jd0 ESM7LlaO5yPC0Q+cxecW754X8YDGL/vgRmsOUA+bOX55/3iFyvTjFCaIU7ugrfjU6+uEUr9c9jY7B NN4hW8EY2EnTflvbuPWJdA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNCsq-00042c-8T; Wed, 01 Feb 2023 08:10:40 -0500 In-Reply-To: (message from Dmitry Gutov on Tue, 31 Jan 2023 20:16:01 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254576 Archived-At: > Date: Tue, 31 Jan 2023 20:16:01 +0200 > Cc: casouri@gmail.com, 60953@debbugs.gnu.org > From: Dmitry Gutov > > > Can you describe what that function should do? I don't think I have a > > clear idea of that. > > In Lisp that function could be implemented as > > (defun buffer-substring-match (regexp &optional start end > inhibit-modify) > (string-match regexp > (buffer-substring (or start (point-min)) > (or end (point-max))) > inhibit-modify)) > > Meaning, it matches the regexp against the buffer substring, with the > string-start and string-end anchors working. > > But it would be implemented in C, meaning we could avoid the extra > consing and funcall overhead. Now I'm confused, because I thought the C functions we were considering all fit the above description. > Anyway, it seems like it might be too late as an addition to Emacs 29. > And we can implement the match predicate using narrowing for this > release, to be updated later. Right, this is not a catastrophe, IMO. The work on TS-based modes is just beginning.