From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61893: 29.0.60; Indentation in c-ts-mode broken again Date: Mon, 06 Mar 2023 14:58:46 +0200 Message-ID: <83zg8q6np5.fsf@gnu.org> References: <83k000fsg8.fsf@gnu.org> <990CFB42-B7E4-4692-858B-20080B19A801@thornhill.no> <83a60wflwm.fsf@gnu.org> <835ybkfhuw.fsf@gnu.org> <3F6EB4C0-8216-4783-9DE4-0719F514F1B7@gmail.com> <83y1ofekaw.fsf@gnu.org> <3B2BAD9F-84AB-4243-AC98-95C52BA492E3@thornhill.no> <0476A0F0-75E4-45EF-9B18-ECC5E87851C1@gmail.com> <5F5AF93A-E0A8-47BF-97DB-1AAA9A025FA4@thornhill.no> <3A152DB8-DA88-4E40-A536-4514E2C3501A@gmail.com> <83ttyz8v4v.fsf@gnu.org> <7CDB5C99-AC13-463A-9B59-B6BB5011E683@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31638"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61893-done@debbugs.gnu.org, theo@thornhill.no, mardani29@yahoo.es To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 06 13:59:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZAQy-00085B-Q9 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Mar 2023 13:59:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZAQj-0006Qx-Ay; Mon, 06 Mar 2023 07:59:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZAQh-0006Q2-4F for bug-gnu-emacs@gnu.org; Mon, 06 Mar 2023 07:59:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZAQg-0008LS-R1 for bug-gnu-emacs@gnu.org; Mon, 06 Mar 2023 07:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZAQg-00057n-EH for bug-gnu-emacs@gnu.org; Mon, 06 Mar 2023 07:59:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Mar 2023 12:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 61893 X-GNU-PR-Package: emacs Mail-Followup-To: 61893@debbugs.gnu.org, eliz@gnu.org, eliz@gnu.org Original-Received: via spool by 61893-done@debbugs.gnu.org id=D61893.167810754019687 (code D ref 61893); Mon, 06 Mar 2023 12:59:02 +0000 Original-Received: (at 61893-done) by debbugs.gnu.org; 6 Mar 2023 12:59:00 +0000 Original-Received: from localhost ([127.0.0.1]:41635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZAQd-00057R-ND for submit@debbugs.gnu.org; Mon, 06 Mar 2023 07:58:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZAQc-00057C-Fi for 61893-done@debbugs.gnu.org; Mon, 06 Mar 2023 07:58:58 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZAQX-0008K6-6j; Mon, 06 Mar 2023 07:58:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=rYK+Vk5yDOla0SCetrXwS6wQLQYSEAyzqy+ARw1YCzg=; b=kjyX7+z+ciyjQlmDLE47 FJeLLsstQgJ+rYQ0eze1HMe7i81vvO/OH+SHFRV9tm6ggv3n3BT51KGg3FORrdxmTn46IA/7Wly5n y+JaZcISqspxBstQOZfN4aI5/nns4Uv4VXT3M1rF2O6YVxjq3ypPhRmx6m1o/0g2pC4beSIFJEpua 3iXNGhs9Gj8q+5dEftE00/sxMsTK0nS/C05OoEzcYrAZl2wJOUnip1WMj5sZv5gsH73Kw2LZ2SfZB TwPp2gHDtZa9UjQBlWPuZHwUuwxrCE1COFcHJ+HJm4dcb9O9dejAz7rvJO0vtiVIWw0dFsaAGnpDp Bbh9p3StzLkRtQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZAQW-0002ix-CL; Mon, 06 Mar 2023 07:58:52 -0500 In-Reply-To: <7CDB5C99-AC13-463A-9B59-B6BB5011E683@gmail.com> (message from Yuan Fu on Sun, 5 Mar 2023 15:26:45 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257387 Archived-At: > From: Yuan Fu > Date: Sun, 5 Mar 2023 15:26:45 -0800 > Cc: Theodor Thornhill , > Daniel Martín , > 61893@debbugs.gnu.org > > > Line 3381 of dispnew.c: type "C-e RET" -- point goes to the correct > > column, but line 3381 is reindented incorrectly. > > This is due to it aligning to the previous sibling, aka the comment. Do we want to skip comments for the “align to the prev sibling” rule? No, this behavior is okay. > > Lines 34529 and 34530 of xdisp.c: "C-e RET" produces incorrect column > > of point and reindents line 34530. > > The preproc directive messed the parse tree, and tree-sitter can’t tell that it’s an else statement, so it can’t be easily fixed sadly. I see. Thanks for the other fixes. I'm closing this bug.