From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62958: [PATCH] Set PAGER=cat in comint.el Date: Thu, 20 Apr 2023 18:56:45 +0300 Message-ID: <83zg724kea.fsf@gnu.org> References: <83edof6oln.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30051"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62958@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 20 17:57:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppWex-0007Zi-3i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Apr 2023 17:57:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppWeg-0007ie-36; Thu, 20 Apr 2023 11:57:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppWed-0007iH-EZ for bug-gnu-emacs@gnu.org; Thu, 20 Apr 2023 11:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppWec-0007q0-UH for bug-gnu-emacs@gnu.org; Thu, 20 Apr 2023 11:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ppWec-0003rg-8X for bug-gnu-emacs@gnu.org; Thu, 20 Apr 2023 11:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Apr 2023 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62958 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62958-submit@debbugs.gnu.org id=B62958.168200620314832 (code B ref 62958); Thu, 20 Apr 2023 15:57:02 +0000 Original-Received: (at 62958) by debbugs.gnu.org; 20 Apr 2023 15:56:43 +0000 Original-Received: from localhost ([127.0.0.1]:38565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppWeI-0003r9-Nf for submit@debbugs.gnu.org; Thu, 20 Apr 2023 11:56:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppWeD-0003qq-P6 for 62958@debbugs.gnu.org; Thu, 20 Apr 2023 11:56:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppWe8-0007eK-3A; Thu, 20 Apr 2023 11:56:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9T0soKzcKwVhIzhKm/9BlvxWjr2TSiZGNVsa2mjhowg=; b=cvBBM0SWmPKy hZ7+I7iUuOhwmpK0ovPf2M2aidcsrS/toVZPi4n67UkL9wkm+RZ6RZXGPHdXwDdB72786KbAeSKPi VNQwlgd2R9l2eDSjee+LlO5ljTAxgjZRj1sveoY7S7shzkZv+zNcNgbXOifxPtdGHIIJWfGRFfPgq HSqT+Co4a/stHx2M+uZzgmYKCNOQ5Tx4DBKinMNaYF9P6emxTa0M9CDLS+VZXZpxY3FvESfrkcGAc 8UkaNnsRxaH7k/vVRXUMU5iOU1vUdRyR+qLV2/DgTKgRhzuPS7QYABUdDecKQ+wcc8ftH0cuynT+3 BU3XIv7uo33sL8qoaf03Xg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppWe7-0005Gs-JQ; Thu, 20 Apr 2023 11:56:31 -0400 In-Reply-To: (message from Spencer Baugh on Thu, 20 Apr 2023 11:47:42 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260345 Archived-At: > From: Spencer Baugh > Cc: 62958@debbugs.gnu.org > Date: Thu, 20 Apr 2023 11:47:42 -0400 > > Eli Zaretskii writes: > > > Sorry, this default cannot be universally correct. You assume that > > 'cat' is always available, which is not true on non-Posix platforms. > > So at the very least the value should be set according to > > executable-find. > > executable-find is not correct in the case of "cat" unfortunately, > because there are programs (git, for one) which if they see PAGER=cat, > just don't start a pager at all, for greater efficiency. (which is > desirable behavior) Is this about removing the leading directories from the value of executable-find? If so, that is trivial to do, and is not the main point of what I wrote. > > Should this test that comint-pager is a string? > > I don't think that's necessary; doing > (if (stringp comint-pager) (list (format "PAGER=%s" comint-pager))) > would have unexpected behavior if comint-pager was accidentally set to a > non-string; doing > (when comint-pager (progn (assert (stringp comint-pager)) > (list (format "PAGER=%s" comint-pager)))) > is a bit verbose and looks weird and is probably not that important. So we are okay with the user setting the variable to a symbol or a list or a vector? Thanks.