all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: me@eshelyaron.com, 63988@debbugs.gnu.org, aaronjensen@gmail.com,
	monnier@iro.umontreal.ca
Subject: bug#63988: 30.0.50; Recent header line format changes cause spin/seg fault with format-mode-line
Date: Wed, 05 Jul 2023 18:40:19 +0300	[thread overview]
Message-ID: <83zg4aicyk.fsf@gnu.org> (raw)
In-Reply-To: <ier1qhmjrz2.fsf@janestreet.com> (message from Spencer Baugh on Wed, 05 Jul 2023 11:30:41 -0400)

> From: Spencer Baugh <sbaugh@janestreet.com>
> Cc: Eshel Yaron <me@eshelyaron.com>,  63988@debbugs.gnu.org,
>    aaronjensen@gmail.com,  monnier@iro.umontreal.ca
> Date: Wed, 05 Jul 2023 11:30:41 -0400
> 
> > It sounds like the consensus here is that indeed this feature is not
> > worth the complications, and so, unless I hear some good reasons not
> > to do so, I intend to delete it in a week's time.
> 
> Ugh, I am only just now seeing this... I would have appreciated a CC
> since I'm the one who requested this feature, or maybe a mail sent to
> the original bug report...
> 
> Anyway, the reason for this feature remains what is described in
> bug#63825: displaying a header line only when there is information to be
> displayed in the header line.

The discussion indicated that the reason for the feature, while it is
valid, is not serious enough to justify the complications described in
the thread.

> Concretely, for which-function-mode: it is nice to have
> which-func-format displayed in the header line, but in some kinds of
> buffers it does not have any information to display.  When a window is
> displaying such a buffer, I'd prefer to not have a header line, because
> the header line will just be empty.
> 
> This use case has no need for the full-fledged :eval mode of this
> feature.  It works fine with the non-nil car case.

That the car is nil doesn't necessarily mean that the header will not
show something.

> I could add this functionality to which-func-mode directly: it could
> learn to set header-line-format buffer-locally only in buffers that
> support which-func-mode.  Would that be acceptable?  If so I'll send a
> patch for that.

If you mean that some Lisp will set header-line-format nil when some
condition is true, I think it should be fine, assuming you can arrange
for this Lisp to run whenever the condition could change.





  reply	other threads:[~2023-07-05 15:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-10  1:09 bug#63988: 30.0.50; Recent header line format changes cause spin/seg fault with format-mode-line Aaron Jensen
2023-06-10  6:47 ` Eli Zaretskii
2023-06-10  8:56   ` Eli Zaretskii
2023-06-10  9:07     ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-15  5:59       ` Eli Zaretskii
2023-06-16  2:30         ` Aaron Jensen
2023-06-23 10:53         ` Eli Zaretskii
2023-07-05 15:30         ` Spencer Baugh
2023-07-05 15:40           ` Eli Zaretskii [this message]
2023-06-10 16:16     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-10 17:42       ` Eli Zaretskii
2023-06-10 17:51         ` Aaron Jensen
2023-06-10 19:11         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-10 11:08   ` Aaron Jensen
2023-06-10 11:22     ` Eli Zaretskii
2023-06-10 11:59       ` Aaron Jensen
2023-06-10 13:04         ` Eli Zaretskii
2023-06-10 15:06           ` Aaron Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zg4aicyk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=63988@debbugs.gnu.org \
    --cc=aaronjensen@gmail.com \
    --cc=me@eshelyaron.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=sbaugh@janestreet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.