From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sun, 16 Jul 2023 14:31:29 +0300 Message-ID: <83zg3w854e.fsf@gnu.org> References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <87ttu4gnpt.fsf@localhost> <83351o9m6h.fsf@gnu.org> <87ilakgmjo.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7587"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 64596@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 13:32:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKzzE-0001mT-TT for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 13:32:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKzyt-0000rW-DQ; Sun, 16 Jul 2023 07:32:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKzys-0000rL-BB for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 07:32:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKzys-0003YR-3P for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 07:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKzyr-0007ub-V3 for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 07:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2023 11:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168950707330350 (code B ref 64596); Sun, 16 Jul 2023 11:32:01 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 16 Jul 2023 11:31:13 +0000 Original-Received: from localhost ([127.0.0.1]:46965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKzy4-0007tR-VO for submit@debbugs.gnu.org; Sun, 16 Jul 2023 07:31:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKzy3-0007tC-JA for 64596@debbugs.gnu.org; Sun, 16 Jul 2023 07:31:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKzxy-0003Nt-4x; Sun, 16 Jul 2023 07:31:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XD7I2+GWqW6AuO4HPWsWRGL7GCqUP53erinBlrqEnKw=; b=lmaplxz9PthM c4+M1k6ZHSfYEeK2G6/NZO5rEIWqZU+trszZNpW7POsZjhxylJm6gLyhBXNFtBH2NpFdWw1YaWuSi V3lP4UgUd2jhG7nz5fjj2VAEsBx+ITzKSNdD9ErnaD32rs3+z29UjKnyRKY7sPzqBRZgBSqCvmL/0 qStuA41qnl52Cxpet26n1fSjkrxcL/QZwX0oxaHlXK2i+UoH9BdB7IckMOVzyV5Y67bDIl9n6H9uj 0mRdsZZ4iRS7u/z8Ft5FmdhhIoQEZliVRBghIDH6RiJzXjAP60qnD8XuK7C85o68G7z4whgUYhAVS WoeOc255ihbH0QwQFk+Wkw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKzxx-0000x9-3L; Sun, 16 Jul 2023 07:31:05 -0400 In-Reply-To: <87ilakgmjo.fsf@localhost> (message from Ihor Radchenko on Sun, 16 Jul 2023 10:47:55 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265318 Archived-At: > From: Ihor Radchenko > Cc: monnier@iro.umontreal.ca, 64596@debbugs.gnu.org > Date: Sun, 16 Jul 2023 10:47:55 +0000 > > Eli Zaretskii writes: > > >> I agree about must_be_updated_p. I had exactly same though that it is > >> redundant with redisplay flag when reading the code. > > > > Look closer, please. The name of the flag might suggest what you say, > > but its usage suggests otherwise. > > Do I understand correctly that prevent_display_optimizations_p in > buffer, must_be_updated_p in window, and garbaged in frames all serve > the same purpose of forcing the redisplay? They all force redisplay, yes, but in different ways. For example, the frame's garbaged flag means the entire frame with all its windows and decorations might need to be redrawn. By contrast, prevent_redisplay_optimizations_p just means "don't use some of the redisplay optimizations that we otherwise could be tempted to try". IOW, not redisplaying a window at all is not an "optimization". > > IOW, prevent_redisplay_optimizations_p must come with the redisplay > > flag set on the buffer/window/frame, but after that it says a > > different thing. > > Then, why not use uniform naming scheme and have the buffer/window/frame > flags names as maybe_redisplay and must_redisplay instead of different > flag name for different object type? Historical reasons. But such naming convention is of secondary importance, IME. As long as the names are not completely misleading, and their effects are well documented, 90% of the job is done.