From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Android port Date: Mon, 07 Aug 2023 14:11:29 +0300 Message-ID: <83zg33nm3i.fsf@gnu.org> References: <1428589171.162865.1691134964773@mail1.libero.it> <87il9s5vmv.fsf@yahoo.com> <83o7jkpbi1.fsf@gnu.org> <7795730.O3cEFmX14Z@nimes> <83leeopaw1.fsf@gnu.org> <87cz0047ar.fsf@yahoo.com> <300293781.6205921.1691334594442@mail1.libero.it> <1869652718.6207009.1691336124300@mail1.libero.it> <373515283.6207381.1691336695284@mail1.libero.it> <83cz00oyy5.fsf@gnu.org> <93167225.6214467.1691345465378@mail1.libero.it> <835y5sowy6.fsf@gnu.org> <1587776676.6215002.1691346895712@mail1.libero.it> <834jlcovco.fsf@gnu.org> <1652040330.6218351.1691353580302@mail1.libero.it> <831qgfpoyu.fsf@gnu.org> <1016606651.3787661.1691392856588@mail1.libero.it> <87cyzz2u6i.fsf@yahoo.com> <87wmy71bsx.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30360"; mail-complaints-to="usenet@ciao.gmane.io" Cc: corwin@bru.st, angelo.g0@libero.it, bruno@clisp.org, eggert@cs.ucla.edu, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 07 13:12:16 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSy9o-0007e1-ME for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Aug 2023 13:12:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSy91-0006q9-2B; Mon, 07 Aug 2023 07:11:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSy8s-0006oM-UY for emacs-devel@gnu.org; Mon, 07 Aug 2023 07:11:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSy8q-00060C-NG; Mon, 07 Aug 2023 07:11:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=dT5qzl/Hbmi42MR0F0s4ROxwrHoJLqWB16ZNcN3QL1Q=; b=lSii8l1tvRWeOFl7oqKJ JDDsVUzaYeIryR8Gy6YBmU/buV7ORBVs3lX6wogfe3vRmqBJzhSZXUc4mXM6MDHdL7TZAiqxPZtLx j3l2PMtPZA+XPgI4z1RAmClwUpKQY/9/0RJYgwE1WNvSq1HeQC9mW0U1B3I4/Z+/ND0h+exlPvyF9 5S9KN26qESI2bAI40fGns6G5jzMg/PEHJrxPKKDvvKsRL9CZAJO5TWOb/wXtfjGCsQl7pfJeDBoD9 UTIOcny0i6e4MrlqX4vSSBg8d/CvS5uzaDBvInNv600vxrnlB/icu/M048tMVHmD9Edkdn1R7mByK ZcFvnimrLtlcHA==; In-Reply-To: <87wmy71bsx.fsf@yahoo.com> (message from Po Lu on Mon, 07 Aug 2023 16:44:46 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308407 Archived-At: > From: Po Lu > Cc: Angelo Graziosi , Eli Zaretskii , > bruno@clisp.org, eggert@cs.ucla.edu, emacs-devel@gnu.org > Date: Mon, 07 Aug 2023 16:44:46 +0800 > > Corwin Brust writes: > > > On Mon, Aug 7, 2023 at 2:22 AM Po Lu wrote: > >> > >> Angelo Graziosi writes: > >> > >> > maybe we have to test master now. Right? > >> > >> It works, since the printf module has been removed. > >> > > > > I'm not able to build the master branch starting from c71a52, here is > > the relevant part of the log (attached), which starts with autogen && > > configure prior to the make, which failed: > > > > GEN ../../etc/charsets/CP1258.map > > CC indent.o > > CC search.o > > fileio.c: In function 'internal_delete_file': > > fileio.c:2601:36: warning: passing argument 1 of > > 'internal_condition_case_2' from incompatible pointer type > > [-Wincompatible-pointer-types] > > 2601 | tem = internal_condition_case_2 (Fdelete_file_internal, filename, > > | ^~~~~~~~~~~~~~~~~~~~~ > > | | > > | struct Lisp_X * (*)(struct Lisp_X *) > > In file included from fileio.c:49: > > lisp.h:4582:47: note: expected 'struct Lisp_X * (*)(struct Lisp_X *, > > struct Lisp_X *)' but argument is of type 'struct Lisp_X * (*)(struct > > Lisp_X *)' > > 4582 | extern Lisp_Object internal_condition_case_2 (Lisp_Object (*) > > (Lisp_Object, Lisp_Object), Lisp_Object, Lisp_Object, Lisp_Object, > > Lisp_Object (*) (Lisp_Object)); > > | > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > fileio.c:2602:40: warning: passing argument 4 of > > 'internal_condition_case_2' from incompatible pointer type > > [-Wincompatible-pointer-types] > > 2602 | Qt, internal_delete_file_1); > > | ^~~~~~~~~~~~~~~~~~~~~~ > > | | > > | struct Lisp_X * > > (*)(struct Lisp_X *) > > In file included from fileio.c:49: > > lisp.h:4582:117: note: expected 'Lisp_Object' {aka 'struct Lisp_X *'} > > but argument is of type 'struct Lisp_X * (*)(struct Lisp_X *)' > > 4582 | extern Lisp_Object internal_condition_case_2 (Lisp_Object (*) > > (Lisp_Object, Lisp_Object), Lisp_Object, Lisp_Object, Lisp_Object, > > Lisp_Object (*) (Lisp_Object)); > > | > > ^~~~~~~~~~~ > > fileio.c:2601:9: error: too few arguments to function > > 'internal_condition_case_2' > > 2601 | tem = internal_condition_case_2 (Fdelete_file_internal, filename, > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > In file included from fileio.c:49: > > lisp.h:4582:20: note: declared here > > 4582 | extern Lisp_Object internal_condition_case_2 (Lisp_Object (*) > > (Lisp_Object, Lisp_Object), Lisp_Object, Lisp_Object, Lisp_Object, > > Lisp_Object (*) (Lisp_Object)); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > GEN ../../etc/charsets/CP10007.map > > CC regex-emacs.o > > GEN ../../etc/charsets/CP720.map > > GEN ../../etc/charsets/CP858.map > > CC undo.o > > make[1]: *** [Makefile:455: fileio.o] Error 1 > > make[1]: *** Waiting for unfinished jobs.... > > > > Let me know if there's other information/digging I might provide. > > > > Note, I updated my script to add V=1 for make in the future. > > I think this is a problem with the fileio stuff Eric installed earlier > instead of the Android port. Simply one of the many hazards of > indiscriminately translating working C to Elisp... Actually, it's partially my fault: I made a mistake in my fix of Eric's changeset. I hope it's fixed now on master.