From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items Date: Sat, 02 Sep 2023 09:41:00 +0300 Message-ID: <83zg259iwz.fsf@gnu.org> References: <87zg4d56l8.fsf@ledu-giraud.fr> <87ilaz1wol.fsf@ledu-giraud.fr> <87fs3xo13z.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16493"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, manuel@ledu-giraud.fr, 64440@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 02 08:42:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcKKu-00042O-Ln for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Sep 2023 08:42:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcKKX-0002EH-S8; Sat, 02 Sep 2023 02:42:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcKKP-0002E4-JD for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 02:41:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcKKP-0001DK-Ad for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 02:41:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcKKY-0002PO-FY for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 02:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 06:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64440-submit@debbugs.gnu.org id=B64440.16936368949218 (code B ref 64440); Sat, 02 Sep 2023 06:42:02 +0000 Original-Received: (at 64440) by debbugs.gnu.org; 2 Sep 2023 06:41:34 +0000 Original-Received: from localhost ([127.0.0.1]:35001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcKK6-0002Ob-BG for submit@debbugs.gnu.org; Sat, 02 Sep 2023 02:41:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcKK4-0002OM-UF for 64440@debbugs.gnu.org; Sat, 02 Sep 2023 02:41:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcKJn-00019B-KI; Sat, 02 Sep 2023 02:41:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dvJhkKmBl9mCQrBIFv6fXcWw7DMmhmSroBdsYxUHhB8=; b=Bj/2ZZ+jHV2d H2h94NxKpg9ibbGK05wAUiOxQpS6wnldnudV+SdBZ6EIA2QrjmBctnCpHAvuShsCclUqc05E5SO/8 oSzKiOgTLxpyeplMzLcFrsGlUoppFEnHCla9u0YLY+Tja0YI3gWHNhV1i3kmdD0RoDatQQsGw3pk2 CeYLp/DI2Kd0J1qNVqHF9V+ugb7UHT2xsBosfOpy20YxgQfO6mqivgiuy0In8UWhG31n0Ug/cDsuW ADtOj4a6rY2/ZA3DMkVC1UBU+xXlEOm6TO85i4whcosw1qmypQnrWNArL9Ux9YGm9aPWYeso9fyg+ 0mouHQ+WH9sXt2c4Xj2R2A==; In-Reply-To: <87fs3xo13z.fsf@yahoo.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268956 Archived-At: > Cc: 64440@debbugs.gnu.org, Manuel Giraud > Date: Sat, 02 Sep 2023 08:44:16 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Stefan Kangas writes: > > >> Here is a new set of patches with two more on top of the previous ones > >> (ie. Number 1 and 2 should be the same as before). > >> > >> Number 3 sets the default mouse cursor to be an arrow on the default > >> menu bar area. Number 4 fixes a flickering I had while moving the mouse > >> pointer *into* a menu bar entry. > > > > Po Lu, do you have any comments on this patch series? > > > > Thanks in advance. > > Thanks. I don't understand why adjustments to note_tab_bar_highlight or > note_tool_bar_highlight are warranted, and I think this ought to be > optional. > > ChangeLog entries are also absent from the commit messages. I'd appreciate a walkthrough of the patches with explanations for the significant hunks. It's a non-trivial change, so I think the rationale and the main ideas of the implementation should be described and discussed. I also have difficulty understanding comments like this one: /* Clear mouse face but the mouse cursor. */ What does it try to say?