From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>, monnier@iro.umontreal.ca
Cc: spacibba@aol.com, 67226@debbugs.gnu.org
Subject: bug#67226: 30.0.50; Regression in previous-complete-history-element with empty input
Date: Sat, 25 Nov 2023 11:39:10 +0200 [thread overview]
Message-ID: <83zfz2cgu9.fsf@gnu.org> (raw)
In-Reply-To: <86leaxsixu.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 16 Nov 2023 19:32:13 +0200)
Stefan, any comments?
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 67226@debbugs.gnu.org
> From: Juri Linkov <juri@linkov.net>
> Date: Thu, 16 Nov 2023 19:32:13 +0200
>
> > When using previous-complete-history-element like:
> >
> > The behavior changed sometime recently, because
> >
> > When the input is empty it shows:
> >
> > [No earlier matching history item]
> >
> > Previously it behaved like `previous-history-element` in that case.
> >
> > Is this intended due to some recent change or is it an issue?
> >
> > ```
> > Emacs -Q
> >
> > M-: (keymap-set minibuffer-local-map "<up>" #'previous-complete-history-element)
> >
> > M-x some-command1
> > M-x some-command2
> > M-x some-command3
> > M-x <up-arrow>
> > ```
>
> The regression is on this line in `previous-matching-history-element`:
>
> (string-match (concat ".*\\(" regexp "\\)") match-string)
>
> In GNU Emacs 29.1.90
>
> (string-match ".*\\(^\\)" "foo")
> => 0
>
> But in GNU Emacs 30.0.50
>
> (string-match ".*\\(^\\)" "foo")
> => nil
>
> Cc:ing Stefan.
>
>
>
>
next prev parent reply other threads:[~2023-11-25 9:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87il62m110.fsf.ref@aol.com>
2023-11-16 10:43 ` bug#67226: 30.0.50; Regression in previous-complete-history-element with empty input Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-16 17:32 ` Juri Linkov
2023-11-25 9:39 ` Eli Zaretskii [this message]
2023-11-25 15:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-25 16:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-25 18:34 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zfz2cgu9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67226@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.