From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 3b1fd42732f: * lisp/loadup.el: Check advice after `rmc.el`; turn error into warning Date: Thu, 14 Dec 2023 09:23:00 +0200 Message-ID: <83zfydqmcr.fsf@gnu.org> References: <170197287539.12661.7539324399514249195@vcs2.savannah.gnu.org> <20231207181435.BCB79C0C6AD@vcs2.savannah.gnu.org> <73d5b60d-afbd-4543-8001-9fe043b4b6ab@vodafonemail.de> <83wmtis4tt.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30815"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca To: Jens Schmidt Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 14 08:23:51 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rDg4V-0007nL-BR for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Dec 2023 08:23:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDg3m-0006OR-UO; Thu, 14 Dec 2023 02:23:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDg3k-0006O3-Nu for emacs-devel@gnu.org; Thu, 14 Dec 2023 02:23:04 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDg3j-0001xm-A0; Thu, 14 Dec 2023 02:23:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uRfxwEKfR8qXuapdAwQIeR3iu5rw9XmllIGYNnkgJwM=; b=nCMr6seRCcl4 668P+xgOH2cAkl7Hhb8NdAeyj0fNS9qdouCyu4CkB4weCBP8jxI23SKZ1I4GF+kjABELBsBr0zBvn CuD+SL3LdQ28nONvmtK1YOKtXCC3kGaiXGCeih/zOUM9ALVbKvbNLDZ3wIrVfybAn3lDgmtYfpsdS RE8Z8Tu5WxeOaIXiiDT/wpuRHkWxgihkQgkwGA/RbqUYLR1TEBIpJ8pzPYcGOqb7A91GfYLD8PBO4 MLdZB/618w0WVhV7Y5eCLp6j/T71qmrgt0SONxH2qiLwRZJlUP4g1Ws6xdxDqMPFKnPM5RTIVxkGZ o5bU5oHYgE4onhIMZd6Vlg==; In-Reply-To: (message from Jens Schmidt on Thu, 14 Dec 2023 00:03:16 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313756 Archived-At: > Date: Thu, 14 Dec 2023 00:03:16 +0100 > From: Jens Schmidt > Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca > > Is rmc (technically) required at all in loadup.el? I tried > bootstrap'ping and check'ing with the attached patch, and these come > through fine. Preloaded files are not preloaded only because they are used during bootstrap. They are preloaded because other preloaded files call their functions in situations that we consider frequent enough to justify preloading. > rmc.el provides autoloaded function `read-multiple-choice', which is > called from `kill-buffer--possibly-save' (defined in simple.el), > which is called from Fkill_buffer (defined in buffer.c), but only > during interactive use. > > Of course, killing buffers is everyday business, but autoloading "rmc" > while prompting for user input should be neglectable, shouldn't it? > And during bootstrap everything should be noninteractive, so "rmc" > wouldn't be required at that time, would it? That might have been a valid question back when we decided to preload rmc, but it's too late to raise it today: I'm quite sure there are enough Lisp programs out there that depend on it being preloaded. And even besides this, kill-buffer is basic enough to have all of its code preloaded. So I don't think we should remove it from loadup.el at this time. > And do I get a free wish from Eli when I help reducing preloaded libs? Only when you do that in time ;-) Thanks.