From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Fri, 12 Jan 2024 14:32:20 +0200 Message-ID: <83zfxaivfv.fsf__4456.86446489475$1705062825$gmane$org@gnu.org> References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83cyyw4of7.fsf@gnu.org> <875y4ovct9.fsf@localhost> <875y04yq9s.fsf@localhost> <875y02y0da.fsf@localhost> <87frz6w2zt.fsf@localhost> <83cyu9nyea.fsf@gnu.org> <87sf35pcds.fsf@localhost> <83y1cxmgws.fsf@gnu.org> <87ttnjj2dp.fsf@localhost> <83bk9rlusw.fsf@gnu.org> <87h6jjj17y.fsf@localhost> <838r4vlt0n.fsf@gnu.org> <87bk9rivzo.fsf@localhost> <8334v3lltf.fsf@gnu.org> <87le8uhh9a.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31941"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65734@debbugs.gnu.org, manikulin@gmail.com, emacs-orgmode@gnu.org, monnier@iro.umontreal.ca, iota@whxvd.name To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 12 13:33:37 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOGjA-00086I-CU for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Jan 2024 13:33:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOGin-0002q7-N6; Fri, 12 Jan 2024 07:33:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOGif-0002jn-1m for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 07:33:06 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOGie-00037Z-OS for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 07:33:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rOGic-0000xH-Kb for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 07:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jan 2024 12:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65734 X-GNU-PR-Package: emacs Original-Received: via spool by 65734-submit@debbugs.gnu.org id=B65734.17050627603642 (code B ref 65734); Fri, 12 Jan 2024 12:33:02 +0000 Original-Received: (at 65734) by debbugs.gnu.org; 12 Jan 2024 12:32:40 +0000 Original-Received: from localhost ([127.0.0.1]:35098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOGiF-0000wf-Tj for submit@debbugs.gnu.org; Fri, 12 Jan 2024 07:32:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOGiD-0000wR-9c for 65734@debbugs.gnu.org; Fri, 12 Jan 2024 07:32:38 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOGi8-0002op-LX; Fri, 12 Jan 2024 07:32:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cuB2vXyaGZ+X28AmeToJKwSMdH0WRpdNWcCzLuzWXRg=; b=T/TGS4AIGWvg XitZmHveD59S9/ZCfhDlTkLLEqp+6h6fnrGOEfpqas6gsEAo8Nm66RVJJcH2nM3L0nArH8BRjsp25 XNHxguP9oznKQMbtlszZ00AKhyY2+nF6m6H4Nda8k3gjAtaXXslIB/Ox0fDfs2pbOQpdC7sD8kD3r HopZjQo/hWcSqV8IbLh4F/g6ecn9/BQlbDB7djM1F1lLHvdZ5Md0CgL1TBvhPU4dSqdFimFmprmd5 /sMwfCHdC0lWiGEjpejZZgpc4ZPlyUjPfqzJLn9Wn3uVirfKMwjkqjFFEbGaKJrx69EO0KIDt6oGd fDBtwdSc9oqAj+X+A54qVw==; In-Reply-To: <87le8uhh9a.fsf@localhost> (message from Ihor Radchenko on Fri, 12 Jan 2024 12:24:01 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278019 Archived-At: > From: Ihor Radchenko > Cc: monnier@iro.umontreal.ca, emacs-orgmode@gnu.org, 65734@debbugs.gnu.org, > manikulin@gmail.com, iota@whxvd.name > Date: Fri, 12 Jan 2024 12:24:01 +0000 > > Eli Zaretskii writes: > > >> Then, Org mode can instead have > >> > >> (setq-local kill-line-query-function #'org-kill-line-query) > >> (defun org-kill-line-query (beg end) > >> (org-with-point-at beg > >> (when (and (org-at-heading-p) > >> (progn > >> (end-of-line) > >> (and (< (point) end) > >> (org-fold-folded-p)))) > >> "Kill hidden subtree along with headline? "))) > > > > I don't know what org-with-point-at and org-fold-folded-p do, but my > > point is that you should consider the case when kill-line kills > > invisible text that has nothing to do with Org's headings and trees, > > so I suggest to either make the detection code smarter (so it could > > distinguish between the two), or make the prompt text vaguer (to not > > claim that the text must be a subtree). > > > > And if that is still not clear or you disagree, let's leave it at > > that. > > I think that I see what you mean. What we can do to achieve this is > changing `kill-line-query-function' into abnormal hook > `kill-line-query-functions'. Then, `kill-line'/`kill-whole-line' will > use (run-hook-with-args-until-success 'kill-line-query-functions) to > decide whether to show a query. > > Does it make sense? It might, yes. But do we have to _replace_ the hook? cannot we have both? I.e. if the new one is defined, call it, otherwise call the old one. That would be more backward-compatible, I think.