From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#2993: 23.0.92; posn-col-row wrong with line-spacing in terminals Date: Tue, 14 Apr 2009 16:59:34 +0300 Message-ID: <83y6u3mj3t.fsf@gnu.org> References: <834owro4ha.fsf@gnu.org> Reply-To: Eli Zaretskii , 2993@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1239719064 13441 80.91.229.12 (14 Apr 2009 14:24:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Apr 2009 14:24:24 +0000 (UTC) Cc: 2993@emacsbugs.donarmstrong.com To: Nikolaj Schumacher Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 14 16:25:38 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LtjZs-0005yo-Mc for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Apr 2009 16:25:33 +0200 Original-Received: from localhost ([127.0.0.1]:55658 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LtjYT-0006Zw-Er for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Apr 2009 10:24:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LtjYN-0006ZW-O9 for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 10:23:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LtjYH-0006Yb-Oo for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 10:23:59 -0400 Original-Received: from [199.232.76.173] (port=33732 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LtjYH-0006YX-LJ for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 10:23:53 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:55763) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LtjYH-0006E8-1J for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 10:23:53 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3EENou6014517; Tue, 14 Apr 2009 07:23:50 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n3EEA4x4010524; Tue, 14 Apr 2009 07:10:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Eli Zaretskii Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 14 Apr 2009 14:10:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2993 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2993-submit@emacsbugs.donarmstrong.com id=B2993.12397176387828 (code B ref 2993); Tue, 14 Apr 2009 14:10:04 +0000 Original-Received: (at 2993) by emacsbugs.donarmstrong.com; 14 Apr 2009 14:00:38 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mtaout1.012.net.il (mtaout1.012.net.il [84.95.2.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3EE0Y0c007808 for <2993@emacsbugs.donarmstrong.com>; Tue, 14 Apr 2009 07:00:36 -0700 Original-Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KI300C00G03DO00@i-mtaout1.012.net.il> for 2993@emacsbugs.donarmstrong.com; Tue, 14 Apr 2009 16:59:27 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.229.34.97]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KI30000SG73Y040@i-mtaout1.012.net.il>; Tue, 14 Apr 2009 16:59:27 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 14 Apr 2009 10:23:59 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27169 Archived-At: > From: Nikolaj Schumacher > Cc: 2993@emacsbugs.donarmstrong.com > Date: Tue, 14 Apr 2009 14:12:12 +0200 > > Eli Zaretskii wrote: > > >> posn-col-row uses the `line-spacing' value in terminals. According to the > >> doc `line-spacing' only has an effect in window systems. > > > > You mean, on graphic displays. > > Yes. > > If that wording is inaccurate, it should also be fixed in the doc > for `line-spacing', which says: "The space is measured in pixels, and > put below lines on window systems." Fixed. Thanks for pointing this out. > --- a/lisp/subr.el > +++ b/lisp/subr.el > @@ -933,8 +933,10 @@ and `event-end' functions." > (x (/ (car pair) (frame-char-width frame))) > (y (/ (cdr pair) (+ (frame-char-height frame) > (or (frame-parameter frame 'line-spacing) > - ;; FIXME: Why the `default'? > - (default-value 'line-spacing) > + (when (display-graphic-p > + (frame-terminal frame)) > + ;; FIXME: Why the `default'? > + (default-value 'line-spacing)) > 0))))) > (cons x y)))))) `display-graphic-p' accepts frames as its argument (see its doc string ;-), so the extra call to `frame-terminal' is unnecessary. Thanks.