From: Eli Zaretskii <eliz@gnu.org>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: david.reitter@gmail.com, emacs-devel@gnu.org
Subject: Re: Truncating scroll runs that copy to where we copied to
Date: Sat, 26 Nov 2011 14:44:02 +0200 [thread overview]
Message-ID: <83y5v36okt.fsf@gnu.org> (raw)
In-Reply-To: <wlmxbnzn4h.wl%mituharu@math.s.chiba-u.ac.jp>
> Date: Wed, 23 Nov 2011 09:41:18 +0900
> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
> Cc: david.reitter@gmail.com,
> emacs-devel@gnu.org
>
> >>>>> On Tue, 22 Nov 2011 04:54:28 -0500, Eli Zaretskii <eliz@gnu.org> said:
>
> > If truncation indirectly prevents copying of disabled rows, then I
> > think at least a comment to that effect should be in the loop which
> > "assigns the rows". Just looking at the loop, it is not at all
> > apparent that only enabled rows are being assigned.
>
> Maybe we can add an assertion as well as such a comment.
Yes, let's do that.
> > The question was whether the current code is right when it
> > unconditionally sets that flag. If the `from' row is disabled, why
> > should its assignee `to' row be enabled? If, after your changes, a
> > disabled row is never assigned, then `to' will already have its
> > enabled_p flag set, by virtue of the assignment. Either way,
> > setting this flag unconditionally after the call to assign_row looks
> > bogus to me. (By contrast, resetting the flag in `from' looks like
> > TRT, at least as long as we garble it.)
>
> Ah, I misunderstood that you were proposing setting to->enabled_p to 1
> unconditionally. Yes, maybe we can replace this assignment with an
> assertion.
Let's do that as well.
Otherwise, I think your changes are fine, thanks. At least I cannot
find anything wrong with them. Please go ahead and install them.
next prev parent reply other threads:[~2011-11-26 12:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 7:13 Truncating scroll runs that copy to where we copied to YAMAMOTO Mitsuharu
2011-11-20 18:23 ` Eli Zaretskii
2011-11-21 0:19 ` YAMAMOTO Mitsuharu
2011-11-21 23:50 ` David Reitter
2011-11-22 6:04 ` Eli Zaretskii
2011-11-22 6:22 ` YAMAMOTO Mitsuharu
2011-11-22 8:25 ` Eli Zaretskii
2011-11-22 8:47 ` YAMAMOTO Mitsuharu
2011-11-22 7:26 ` YAMAMOTO Mitsuharu
2011-11-22 8:52 ` Eli Zaretskii
2011-11-22 9:09 ` YAMAMOTO Mitsuharu
2011-11-22 9:54 ` Eli Zaretskii
2011-11-23 0:41 ` YAMAMOTO Mitsuharu
2011-11-26 12:44 ` Eli Zaretskii [this message]
2011-11-28 1:10 ` YAMAMOTO Mitsuharu
2011-11-22 0:33 ` YAMAMOTO Mitsuharu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y5v36okt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=david.reitter@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.