From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11604: USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup. Date: Sun, 03 Jun 2012 17:31:18 +0300 Message-ID: <83y5o4bh6x.fsf@gnu.org> References: <4FC9522B.7050302@cs.ucla.edu> <83k3zqcgqg.fsf@gnu.org> <4FCB091F.4050602@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1338734573 2379 80.91.229.3 (3 Jun 2012 14:42:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 3 Jun 2012 14:42:53 +0000 (UTC) Cc: 11604@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 03 16:42:51 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SbC0w-0008KC-7q for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2012 16:42:42 +0200 Original-Received: from localhost ([::1]:40461 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbBsi-0002YO-6V for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2012 10:34:12 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbBqn-00007d-7Y for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 10:32:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SbBql-0003L8-8d for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 10:32:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbBql-0003Kz-50 for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 10:32:11 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SbBsY-0001Na-6X for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 10:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jun 2012 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11604 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11604-submit@debbugs.gnu.org id=B11604.13387339945244 (code B ref 11604); Sun, 03 Jun 2012 14:34:02 +0000 Original-Received: (at 11604) by debbugs.gnu.org; 3 Jun 2012 14:33:14 +0000 Original-Received: from localhost ([127.0.0.1]:55857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SbBrl-0001MX-JH for submit@debbugs.gnu.org; Sun, 03 Jun 2012 10:33:13 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:35662) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SbBri-0001MJ-Ov for 11604@debbugs.gnu.org; Sun, 03 Jun 2012 10:33:11 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M5100500PLIXL00@a-mtaout22.012.net.il> for 11604@debbugs.gnu.org; Sun, 03 Jun 2012 17:31:12 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M5100526PNZAXB0@a-mtaout22.012.net.il>; Sun, 03 Jun 2012 17:31:12 +0300 (IDT) In-reply-to: <4FCB091F.4050602@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60668 Archived-At: > Date: Sat, 02 Jun 2012 23:50:07 -0700 > From: Paul Eggert > CC: 11604@debbugs.gnu.org > > >> + (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the > >> + code works fine either way, and efficiency is not a concern here. > > > > why isn't efficiency a concern? > > Because the union type is for debugging, not for production. I didn't know that. If that is so, it should be mentioned in the comments somewhere. (I actually thought that Stefan wants to move to that model for production at some point, but maybe I misunderstood.) > > Also, which parts of gnulib make 'static inline' portable? If it > > isn't in a part that is used by the MS-Windows port, the MSVC build is > > still being screwed by these changes. > > Mostly, it's the AC_C_INLINE stuff in m4/*. Yes, but where in the gnulib stuff that is compiled does it make 'static inline' portable? The m4/* files aren't used for compiling and linking, so that's not the answer I was looking for. > 'static inline' been used for some time in Emacs, and it works just > fine with the MSVC build. I believe you, but I'd like still to make sure I understand all the aspects of this.