From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#15365: 24.3.50; Segfault when calling vc-git-log-edit-toggle-amend Date: Sat, 14 Sep 2013 13:16:12 +0300 Message-ID: <83y56zg13n.fsf@gnu.org> References: <8761u5rl5c.fsf@yandex.ru> <83zjrghnca.fsf@gnu.org> <5233B818.5050705@yandex.ru> <838uyzhlv5.fsf@gnu.org> <52341F9A.6030102@gmx.at> <837gejhj7v.fsf@gnu.org> <523430BB.2070902@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1379153839 31420 80.91.229.3 (14 Sep 2013 10:17:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Sep 2013 10:17:19 +0000 (UTC) Cc: 15365@debbugs.gnu.org, dgutov@yandex.ru To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 14 12:17:18 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VKmuj-0002WP-Sr for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Sep 2013 12:17:18 +0200 Original-Received: from localhost ([::1]:52633 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKmuj-0004uk-Ey for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Sep 2013 06:17:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKmub-0004uO-NS for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 06:17:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKmuV-0000qG-CH for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 06:17:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55800) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKmuV-0000q9-8W for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 06:17:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VKmuU-0007dE-FG for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 06:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Sep 2013 10:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15365 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15365-submit@debbugs.gnu.org id=B15365.137915379229293 (code B ref 15365); Sat, 14 Sep 2013 10:17:02 +0000 Original-Received: (at 15365) by debbugs.gnu.org; 14 Sep 2013 10:16:32 +0000 Original-Received: from localhost ([127.0.0.1]:35860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKmtz-0007cO-Ow for submit@debbugs.gnu.org; Sat, 14 Sep 2013 06:16:32 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:45401) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKmtw-0007cA-Ky for 15365@debbugs.gnu.org; Sat, 14 Sep 2013 06:16:29 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MT400A001IWXX00@a-mtaout20.012.net.il> for 15365@debbugs.gnu.org; Sat, 14 Sep 2013 13:16:22 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MT400A4K1V9R070@a-mtaout20.012.net.il>; Sat, 14 Sep 2013 13:16:22 +0300 (IDT) In-reply-to: <523430BB.2070902@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78395 Archived-At: > Date: Sat, 14 Sep 2013 11:47:39 +0200 > From: martin rudalics > CC: dgutov@yandex.ru, 15365@debbugs.gnu.org > > >> So where was Dmitry's cursor? > > > > At PT, whose value was 78. > > So PT was not in the window and the fact that it apparently passed the > earlier check (PT < CHARPOS (start)) means that PT was after the end of > the window. Is that conclusion correct? No. It was in the 3rd line: 0: edges=(1,77),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0 1: edges=(77,78),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0 2: edges=(78,79),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0 As you see, the 3rd line begins with character position 78, and that's where point is. So the cursor should be displayed there. > > But I probably don't understand what you wanted to ask or tell. > > Figure out why row_containing_pos (w, PT, r0, NULL, 0) returned 0. That's easy: r0->enabled_p is zero (that's what enb=0 is about). And row_containing_pos immediately returns NULL in that case. > And why try_window_id was supposed to abort in this case and why > this abort didn't occur more frequently. My analysis concluded that it wasn't supposed to abort, just not call set_cursor_from_row in that case. The call to abort was added long ago, when row_containing_pos got a minor modification, and the person who made the change thought that perhaps that change will cause damage. I think we can remove that call to abort now. And if that causes any regressions, there's a more drastic way of calling GIVE_UP in that case.