From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 15365@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#15365: 24.3.50; Segfault when calling vc-git-log-edit-toggle-amend
Date: Sat, 14 Sep 2013 13:16:12 +0300 [thread overview]
Message-ID: <83y56zg13n.fsf@gnu.org> (raw)
In-Reply-To: <523430BB.2070902@gmx.at>
> Date: Sat, 14 Sep 2013 11:47:39 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: dgutov@yandex.ru, 15365@debbugs.gnu.org
>
> >> So where was Dmitry's cursor?
> >
> > At PT, whose value was 78.
>
> So PT was not in the window and the fact that it apparently passed the
> earlier check (PT < CHARPOS (start)) means that PT was after the end of
> the window. Is that conclusion correct?
No. It was in the 3rd line:
0: edges=(1,77),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0
1: edges=(77,78),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0
2: edges=(78,79),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0
As you see, the 3rd line begins with character position 78, and that's
where point is. So the cursor should be displayed there.
> > But I probably don't understand what you wanted to ask or tell.
>
> Figure out why row_containing_pos (w, PT, r0, NULL, 0) returned 0.
That's easy: r0->enabled_p is zero (that's what enb=0 is about). And
row_containing_pos immediately returns NULL in that case.
> And why try_window_id was supposed to abort in this case and why
> this abort didn't occur more frequently.
My analysis concluded that it wasn't supposed to abort, just not call
set_cursor_from_row in that case. The call to abort was added long
ago, when row_containing_pos got a minor modification, and the person
who made the change thought that perhaps that change will cause
damage. I think we can remove that call to abort now. And if that
causes any regressions, there's a more drastic way of calling GIVE_UP
in that case.
next prev parent reply other threads:[~2013-09-14 10:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 11:55 bug#15365: 24.3.50; Segfault when calling vc-git-log-edit-toggle-amend Dmitry Gutov
2013-09-13 13:18 ` Eli Zaretskii
2013-09-14 1:12 ` Dmitry Gutov
2013-09-14 8:02 ` Eli Zaretskii
2013-09-14 8:34 ` martin rudalics
2013-09-14 8:59 ` Eli Zaretskii
2013-09-14 9:47 ` martin rudalics
2013-09-14 10:16 ` Eli Zaretskii [this message]
2013-09-14 13:08 ` Dmitry Gutov
2013-09-14 13:45 ` Eli Zaretskii
2013-09-15 3:01 ` Dmitry Gutov
2013-09-15 6:20 ` Eli Zaretskii
2013-09-15 14:53 ` Dmitry Gutov
2013-09-14 13:05 ` Dmitry Gutov
2013-09-14 13:29 ` Eli Zaretskii
2013-09-19 8:23 ` Eli Zaretskii
2013-09-22 5:00 ` Dmitry Gutov
2013-09-22 7:14 ` Eli Zaretskii
2013-09-14 14:37 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y56zg13n.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=15365@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.