From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17388: 24.4.50; REGRESSION: Ediff - 1) wrong face, 2) incorrect diffing Date: Sat, 03 May 2014 19:42:12 +0300 Message-ID: <83y4yizue3.fsf@gnu.org> References: <87wqe43t55.fsf@rosalinde.fritz.box> <111c9271-6a23-426e-adb2-ff5520c02806@default> <83a9az1hok.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1399135406 22354 80.91.229.3 (3 May 2014 16:43:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 May 2014 16:43:26 +0000 (UTC) Cc: 17388@debbugs.gnu.org, kifer@cs.stonybrook.edu To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 03 18:43:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wgd1v-0002Lp-0k for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 May 2014 18:43:15 +0200 Original-Received: from localhost ([::1]:49588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wgd1u-0007Wo-D6 for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 May 2014 12:43:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wgd1n-0007WV-F5 for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 12:43:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wgd1j-0007X2-0i for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 12:43:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wgd1i-0007Wy-TX for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 12:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wgd1i-0006Yq-6u for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 12:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 May 2014 16:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17388 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17388-submit@debbugs.gnu.org id=B17388.139913534225160 (code B ref 17388); Sat, 03 May 2014 16:43:02 +0000 Original-Received: (at 17388) by debbugs.gnu.org; 3 May 2014 16:42:22 +0000 Original-Received: from localhost ([127.0.0.1]:49895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wgd14-0006Xj-8C for submit@debbugs.gnu.org; Sat, 03 May 2014 12:42:22 -0400 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:57525) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wgd10-0006XQ-Uc for 17388@debbugs.gnu.org; Sat, 03 May 2014 12:42:19 -0400 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0N5000300B0ZCG00@mtaout24.012.net.il> for 17388@debbugs.gnu.org; Sat, 03 May 2014 19:39:51 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N5000OTSBME4K50@mtaout24.012.net.il>; Sat, 03 May 2014 19:39:51 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88594 Archived-At: > Date: Sat, 3 May 2014 07:01:13 -0700 (PDT) > From: Drew Adams > Cc: monnier@iro.umontreal.ca, 17388@debbugs.gnu.org, kifer@cs.stonybrook.edu > > > > There should be EITHER, (a) as previously, NO fine diffs shown for > > > other than the current diff OR (b) CORRECT (helpful) fine diffs > > > shown for the non-current diffs. > > > > Ediff's "fine diffs" are word-granular. That is, Ediff breaks each > > line into "words", then passes the result to the Diff program for > > comparisoon, and reflects the results with different faces. AFAIR, > > this has always been that way. > > OK, so you are saying that Emacs has silently changed to (b) from (a), > and the way it does fine diffs corresponds to what is shown. Yes. But Stefan now changed it back. Therefore, I was talking only about the 2nd part of your report, which complains that the fine diffs are incorrect. > > > > I see both of these problematic highlightings on GNU/Linux builds from > > > > both the trunk (bzr 117042) and the emacs-24 branch (bzr 117049). > > > > I can confirm that too, but (a) I don't think the 2nd issue > > constitutes a "problem" (see above), and (b) it is definitely not a > > "REGRESSION", because older Emacsen behaved the same wrt fine diffs > > inside a line. > > It is a change in behavior wrt older Emacsen, which do not show fine > diffs within the non-current diffs. Again, that part is now gone; Emacs behaves like before: it shows fine diffs only in the current hnunk. > But more importantly, "REGRESSION" in the subject line is for the bug > report, and #1 is the more serious part: removing diff highlighting > from part of a diff gives the impression that that unhighlighted text > is not different. #1 is solved; do you agree that #2 is not a bug, but the intended behavior that was always there?