From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Everyone, please stop making my life more difficult Date: Fri, 12 Sep 2014 13:33:48 +0300 Message-ID: <83y4tp6sc3.fsf@gnu.org> References: <20140912043652.4D6D8380604@snark.thyrsus.com> <834mwd8j6a.fsf@gnu.org> <20140912095542.GD32586@thyrsus.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1410518069 26988 80.91.229.3 (12 Sep 2014 10:34:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 12 Sep 2014 10:34:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: esr@thyrsus.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 12 12:34:21 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XSOBI-0003fZ-88 for ged-emacs-devel@m.gmane.org; Fri, 12 Sep 2014 12:34:20 +0200 Original-Received: from localhost ([::1]:43992 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSOBH-0004fA-MR for ged-emacs-devel@m.gmane.org; Fri, 12 Sep 2014 06:34:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSOB0-0004eO-Iv for emacs-devel@gnu.org; Fri, 12 Sep 2014 06:34:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSOAr-0006J9-TE for emacs-devel@gnu.org; Fri, 12 Sep 2014 06:34:02 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:33984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSOAr-0006Gs-L8 for emacs-devel@gnu.org; Fri, 12 Sep 2014 06:33:53 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NBS00K00A0X2W00@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Fri, 12 Sep 2014 13:33:51 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NBS00J9GAOFZK80@a-mtaout23.012.net.il>; Fri, 12 Sep 2014 13:33:51 +0300 (IDT) In-reply-to: <20140912095542.GD32586@thyrsus.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.175 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:174202 Archived-At: > Date: Fri, 12 Sep 2014 05:55:43 -0400 > From: "Eric S. Raymond" > Cc: emacs-devel@gnu.org > > Eli Zaretskii : > > > 1) People are continuing to embed bzr revision numbers like > > > r99634.2.576 and r102428 in comments. Do not do this. > > > > There's no easy way to refer to an old commit in an unequivocal way. > > Its date and committer is pretty unambiguous. But less than useful when you need to look up that commit by that spec. AFAIK, we don't have VC commands that can look up a commit given such a spec, so it requires tedious manual work. > > > 2) "eliz@gnu.org-20101113210758-8ml5kibjtza5ysmb" Um. What the *hell*? > > > > It's a bzr revision-id. You can use it in "bzr log" or any other bzr > > command that accepts a revision spec. > > Well, at least that makes it less arbitrary. But still soon to become > meaningless, and I still have to fix it. You already have other such references in the logs, so I was quite sure that problem was solved. These revision-ids are in fixed format, so there should be no need for heuristics in finding the corresponding commit, nor do I see a need for a list of conversions when the revision is referenced by such an ID. This is why I added them in the first place in this case: to make your job easier, not harder. > One I have the location of one of these, it's a simple regex > transformation to turn it into a ! > portable revision stamp. The expensive part will be finding them all. With revision-ids, it's not supposed to be expensive. > And I can't do the replacement mechanically, because this: a reference > pair consisting of a short revision ID and one of these long-form ones > would get turned into two duplicate version stamps. You can replace the "dotted" revno with nothing in this case. > Avoiding that is going to take wearying handhacking, and I am unhappy > that it is required. I didn't ask everyone to start using portable revision > stamps months ago because I like hearing myself talk - there have been > real consequences because people didn't, and now I'm going to have to > write more machinery to just to be sure I've *found* all these > goddamned long-form IDs so I can patch them out manually. With > conversion overhead making my tests take forever I figure I'm looking > at maybe five days of intermittent boring shit-work to cope with this. Why do you run this conversion regularly at all? Why not do it once on the D-Day? > > Is it possible to write a command to do this? > > I know how to do it using a script wrapper around git log. The > central bit of magic is this: > > git log -1 --pretty='%ci!%ce' $1 > > The output from that needs trivial editing in the date part. This produces the local time, while we need UTC (a.k.a. "Zulu"). Is there a way to have a UTC time?