From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20628: 25.0.50; Incorrect line height for some fonts Date: Wed, 27 May 2015 18:20:02 +0300 Message-ID: <83y4kaxd25.fsf@gnu.org> References: <20150522.234959.238191883.wl@gnu.org> <556189D0.2000208@live.com> <83bnha1fxw.fsf@gnu.org> <20150524.113203.250674550.wl@gnu.org> <83617i1f29.fsf@gnu.org> <834mn21e7y.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1432740113 17410 80.91.229.3 (27 May 2015 15:21:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 May 2015 15:21:53 +0000 (UTC) Cc: 20628@debbugs.gnu.org To: wl@gnu.org, clement.pitclaudel@live.com, ohwoeowho@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 27 17:21:44 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yxd8v-0001yC-8g for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 May 2015 17:21:17 +0200 Original-Received: from localhost ([::1]:54385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxd8u-0001VG-Ky for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 May 2015 11:21:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxd8n-0001Re-Dj for bug-gnu-emacs@gnu.org; Wed, 27 May 2015 11:21:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxd8i-00019K-Df for bug-gnu-emacs@gnu.org; Wed, 27 May 2015 11:21:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxd8i-00019C-9z for bug-gnu-emacs@gnu.org; Wed, 27 May 2015 11:21:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Yxd8h-0002X1-Pp for bug-gnu-emacs@gnu.org; Wed, 27 May 2015 11:21:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 May 2015 15:21:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20628-submit@debbugs.gnu.org id=B20628.14327400279674 (code B ref 20628); Wed, 27 May 2015 15:21:03 +0000 Original-Received: (at 20628) by debbugs.gnu.org; 27 May 2015 15:20:27 +0000 Original-Received: from localhost ([127.0.0.1]:58504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yxd82-0002Vs-JU for submit@debbugs.gnu.org; Wed, 27 May 2015 11:20:26 -0400 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:33862) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yxd7x-0002Vb-Er for 20628@debbugs.gnu.org; Wed, 27 May 2015 11:20:21 -0400 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NP000K00KW6A900@mtaout25.012.net.il> for 20628@debbugs.gnu.org; Wed, 27 May 2015 18:16:01 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NP000EG4L2P4L70@mtaout25.012.net.il>; Wed, 27 May 2015 18:16:01 +0300 (IDT) In-reply-to: <834mn21e7y.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103219 Archived-At: > Date: Sun, 24 May 2015 13:06:57 +0300 > From: Eli Zaretskii > Cc: 20628@debbugs.gnu.org > > Actually, I need help with this, as I don't know enough about fonts, > and don't have access to systems where per-character ascent/descent > values are currently available in Emacs. Since no one volunteered, I've pushed an experimental branch scratch/large-fonts, which attempts to deal with the problem. After looking into the relevant code and trying a few things, I concluded that I don't want to stop using the font-global height information for fonts that provide reasonable values. That's because the current code works well enough in those cases, and it would be a shame to throw it out the window. Also, it turns out that the assumptions about using font-global values are all over the place, and in some of them the per-glyph information is not even available. So instead I added a heuristic test intended to detect the problematic fonts, and code to fall back on the per-glyph data when such fonts are detected. I also fixed a few issues exposed by this change, mainly with the hollow cursor. The changes are in platform-independent code, but I could only test them on MS-Windows. So users of Unix and GNU systems who are affected by this problem are encouraged to try the branch and report their experiences, whether good or bad. I will look into merging the branch to master in a few days, barring any grave bugs. TIA