From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add shell-quasiquote. Date: Sun, 18 Oct 2015 18:54:41 +0300 Message-ID: <83y4f0i33y.fsf@gnu.org> References: <87si59wj42.fsf@T420.taylan> <83eggt4esi.fsf@gnu.org> <87fv19wh7b.fsf@T420.taylan> <83bnbx4d7e.fsf@gnu.org> <87twppuzfu.fsf@T420.taylan> <83a8rh48if.fsf@gnu.org> <87io65utmt.fsf@T420.taylan> <5622B3C6.4030208@cs.ucla.edu> <871tctuqw5.fsf@T420.taylan> <5622C340.1050001@cs.ucla.edu> <87lhb1t9sm.fsf@T420.taylan> <56230695.4070501@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1445183733 3609 80.91.229.3 (18 Oct 2015 15:55:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 18 Oct 2015 15:55:33 +0000 (UTC) Cc: taylanbayirli@gmail.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 18 17:55:21 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZnqIp-0004kc-D5 for ged-emacs-devel@m.gmane.org; Sun, 18 Oct 2015 17:55:19 +0200 Original-Received: from localhost ([::1]:34364 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnqIo-0006Gb-Jp for ged-emacs-devel@m.gmane.org; Sun, 18 Oct 2015 11:55:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnqIk-0006F6-SO for emacs-devel@gnu.org; Sun, 18 Oct 2015 11:55:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZnqIg-00087K-SR for emacs-devel@gnu.org; Sun, 18 Oct 2015 11:55:14 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:60206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnqIg-00087D-KZ for emacs-devel@gnu.org; Sun, 18 Oct 2015 11:55:10 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NWF00000AJYMC00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sun, 18 Oct 2015 18:54:40 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NWF00095AV4D570@a-mtaout20.012.net.il>; Sun, 18 Oct 2015 18:54:40 +0300 (IDT) In-reply-to: <56230695.4070501@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191960 Archived-At: > From: Paul Eggert > Date: Sat, 17 Oct 2015 19:40:21 -0700 > Cc: emacs-devel@gnu.org >=20 > Taylan Ulrich Bay=C4=B1rl=C4=B1/Kammer wrote: > > Please tell me which shells shell-quote-argument is guaranteed to= work > > safely on >=20 > Nobody can tell you that. What we can tell you is that shell-quote-= argument=20 > works on a superset of uses that shqq--quote-string works on. The t= rust-based=20 > arguments against using shell-quote-argument all apply, with greate= r force,=20 > against using shqq--quote-string. For example, shqq--quote-string i= s more=20 > vulnerable to code-injection attacks than shell-quote-argument is. >=20 > I am not a fan of non-POSIX shells. They are a hassle to deal with = and can cause=20 > significant problems in Emacs maintenance. In areas where they are = a significant=20 > problem, we don't need to support them. But this particular instanc= e is not a=20 > significant problem. Emacs already has a portable, tested, easy-to-= use function=20 > to quote shell arguments, and there's good reason to use it here. I completely agree with everything Paul wrote here.