From: Eli Zaretskii <eliz@gnu.org>
To: Yuan MEI <yuan.mei.list@gmail.com>
Cc: rudalics@gmx.at, emacs-devel@gnu.org
Subject: Re: Font related crash?
Date: Thu, 05 Nov 2015 18:26:59 +0200 [thread overview]
Message-ID: <83y4ecs97w.fsf@gnu.org> (raw)
In-Reply-To: <CANGGyWb9Nq2PQmo4fGazVHi2XP3MNEBzL-4xLbwJ05vXffCZrA@mail.gmail.com>
> Date: Thu, 5 Nov 2015 00:45:51 -0800
> From: Yuan MEI <yuan.mei.list@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel <emacs-devel@gnu.org>
>
> Program received signal SIGFPE, Arithmetic exception.
> 0x0000000000413a88 in required_matrix_width (w=w@entry=0x21db2f8)
> at dispnew.c:1727
> 1727 / ch_width) * w->ncols_scale_factor
> (gdb) p ch_width
> $1 = 0
> (gdb) p w->ncols_scale_factor
> $2 = 1
> (gdb) p WINDOW_PIXEL_WIDTH (w)
> $3 = 96
> (gdb)
Martin, this probably means the code in font_open_entity, which AFAICS
is the only place where we set FRAME_SMALLEST_CHAR_WIDTH, was not yet
called for this frame, or maybe it was called, but the logic there
that assigns a value to the above is flawed.
Such a small pixel width probably means the former, in which case I
think we need some simple protection in required_matrix_width against
FRAME_SMALLEST_CHAR_WIDTH being zero (and a similar protection in
required_matrix_height, to be called next).
Or maybe when we create a frame we should simply initialize
FRAME_SMALLEST_CHAR_WIDTH to 1 (and similarly with
FRAME_SMALLEST_FONT_HEIGHT).
next prev parent reply other threads:[~2015-11-05 16:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 22:32 Font related crash? Yuan MEI
2015-11-05 3:37 ` Eli Zaretskii
2015-11-05 6:55 ` Yuan MEI
2015-11-05 7:55 ` martin rudalics
2015-11-05 8:45 ` Yuan MEI
2015-11-05 16:26 ` Eli Zaretskii [this message]
2015-11-05 18:16 ` martin rudalics
2015-11-05 18:42 ` Eli Zaretskii
2015-11-06 10:31 ` Yuan MEI
2015-11-06 10:50 ` Eli Zaretskii
2015-11-06 11:26 ` martin rudalics
2015-11-06 11:25 ` martin rudalics
2015-11-07 5:52 ` Yuan MEI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y4ecs97w.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rudalics@gmx.at \
--cc=yuan.mei.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.