From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: setq's with missing final arguments. Date: Sun, 22 Nov 2015 17:44:55 +0200 Message-ID: <83y4dq2g3s.fsf@gnu.org> References: <20151122122657.GA2332@acm.fritz.box> <87egfi5h8i.fsf@igel.home> <87h9ke9o6x.fsf@fencepost.gnu.org> <87a8q65gd6.fsf@igel.home> <87d1v29nih.fsf@fencepost.gnu.org> <87610u5f9g.fsf@igel.home> <20151122141031.GB2332@acm.fritz.box> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1448207125 18292 80.91.229.3 (22 Nov 2015 15:45:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Nov 2015 15:45:25 +0000 (UTC) Cc: dak@gnu.org, schwab@linux-m68k.org, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 22 16:45:15 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a0WpG-0000Dt-T5 for ged-emacs-devel@m.gmane.org; Sun, 22 Nov 2015 16:45:15 +0100 Original-Received: from localhost ([::1]:56491 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0WpG-0003Dr-TN for ged-emacs-devel@m.gmane.org; Sun, 22 Nov 2015 10:45:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0WpD-0003DW-0m for emacs-devel@gnu.org; Sun, 22 Nov 2015 10:45:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0WpC-0000oq-A4 for emacs-devel@gnu.org; Sun, 22 Nov 2015 10:45:10 -0500 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:48968) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0Wp7-0000k4-DB; Sun, 22 Nov 2015 10:45:05 -0500 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NY800K0032BFW00@mtaout24.012.net.il>; Sun, 22 Nov 2015 17:37:54 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NY800CT33F5ZI60@mtaout24.012.net.il>; Sun, 22 Nov 2015 17:37:54 +0200 (IST) In-reply-to: <20151122141031.GB2332@acm.fritz.box> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.180 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195026 Archived-At: > Date: Sun, 22 Nov 2015 14:10:31 +0000 > From: Alan Mackenzie > Cc: David Kastrup , emacs-devel@gnu.org > > > The byte-compiler is not for imposing coding style. > > That is why I proposed issuing a warning, not an error. In the actual > case I found, it was indeed an error. > > > If it is wrong for setq to accept implit nil then it should be changed > > in setq and only then in the byte-compiler. > > I would be happy enough for a missing final argument to setq to be an > error. But until that stage is reached, I think issuing a warning is > appropriate. But I disagree with you about priorities: it is more > important to catch the violations in our compiled code than worry about > the interpreted version. As long as 'setq' accepts this use case, it is not a violation.