From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23483: 24.5; cygwin emacs w32 doesn not ask to save files when windows shuts down Date: Tue, 10 May 2016 19:32:26 +0300 Message-ID: <83y47hc1r9.fsf@gnu.org> References: <83a8k0e6l3.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1462898011 15458 80.91.229.3 (10 May 2016 16:33:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 May 2016 16:33:31 +0000 (UTC) Cc: strozzi2@llnl.gov, 23483@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 10 18:33:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b0Aaz-0005EQ-U8 for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 May 2016 18:33:18 +0200 Original-Received: from localhost ([::1]:47512 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0Aaz-0003dN-0a for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 May 2016 12:33:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0Aar-0003Y6-1S for bug-gnu-emacs@gnu.org; Tue, 10 May 2016 12:33:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0Aak-0006kH-Bn for bug-gnu-emacs@gnu.org; Tue, 10 May 2016 12:33:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0Aak-0006k4-1g for bug-gnu-emacs@gnu.org; Tue, 10 May 2016 12:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b0Aaj-0002BH-LU for bug-gnu-emacs@gnu.org; Tue, 10 May 2016 12:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 May 2016 16:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23483 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23483-submit@debbugs.gnu.org id=B23483.14628979578351 (code B ref 23483); Tue, 10 May 2016 16:33:01 +0000 Original-Received: (at 23483) by debbugs.gnu.org; 10 May 2016 16:32:37 +0000 Original-Received: from localhost ([127.0.0.1]:46096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0AaK-0002Ad-Pw for submit@debbugs.gnu.org; Tue, 10 May 2016 12:32:36 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0AaJ-0002AS-Ms for 23483@debbugs.gnu.org; Tue, 10 May 2016 12:32:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0AaA-0006Wv-Gr for 23483@debbugs.gnu.org; Tue, 10 May 2016 12:32:30 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0AaA-0006WU-EO; Tue, 10 May 2016 12:32:26 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2898 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b0Aa6-0004im-Qh; Tue, 10 May 2016 12:32:24 -0400 In-reply-to: (message from Ken Brown on Tue, 10 May 2016 11:16:44 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118068 Archived-At: > Cc: 23483@debbugs.gnu.org > From: Ken Brown > Date: Tue, 10 May 2016 11:16:44 -0400 > > > If someone submits patches that listen to system shutdown messages, > > and auto-save files when they arrive, this can be fixed. Patches > > welcome. > > I asked about this on the Cygwin list (https://www.cygwin.com/ml/cygwin/2016-05/msg00085.html). Based on the response I got, I tried the following, which seems to work: > > diff --git a/src/w32fns.c b/src/w32fns.c > index ede8f6b..705b978 100644 > --- a/src/w32fns.c > +++ b/src/w32fns.c > @@ -4795,6 +4795,9 @@ w32_wnd_proc (HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) > my_post_msg (&wmsg, hwnd, msg, wParam, lParam); > return 0; > > + case WM_ENDSESSION: > + terminate_due_to_signal (SIGTERM, 0); > + Thanks. However, w32_wnd_proc runs in a separate thread, so I don't think you can safely call terminate_due_to_signal from there, because the latter will call Lisp. IOW, the above can crash in "interesting" ways. What I think we need to do instead is send a message to the main thread that will produce a special event, and then bind that event to kill-emacs (probably in special-event-map).