From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23536: 25.1.50; viper-mode "/" search includes "(default ...) " prefix Date: Sat, 14 May 2016 11:50:06 +0300 Message-ID: <83y47d6n29.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1463215883 24449 80.91.229.3 (14 May 2016 08:51:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 May 2016 08:51:23 +0000 (UTC) Cc: 23536@debbugs.gnu.org To: Jim Meyering Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 14 10:51:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b1VHy-0003gS-E2 for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 May 2016 10:51:10 +0200 Original-Received: from localhost ([::1]:37115 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1VHx-0008Um-RL for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 May 2016 04:51:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1VHu-0008QL-Cq for bug-gnu-emacs@gnu.org; Sat, 14 May 2016 04:51:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b1VHq-0004q2-58 for bug-gnu-emacs@gnu.org; Sat, 14 May 2016 04:51:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1VHq-0004py-1f for bug-gnu-emacs@gnu.org; Sat, 14 May 2016 04:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b1VHp-0004EM-Q6 for bug-gnu-emacs@gnu.org; Sat, 14 May 2016 04:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 May 2016 08:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23536 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23536-submit@debbugs.gnu.org id=B23536.146321580416186 (code B ref 23536); Sat, 14 May 2016 08:51:01 +0000 Original-Received: (at 23536) by debbugs.gnu.org; 14 May 2016 08:50:04 +0000 Original-Received: from localhost ([127.0.0.1]:50426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b1VGu-0004Cz-3E for submit@debbugs.gnu.org; Sat, 14 May 2016 04:50:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b1VGr-0004CQ-JZ for 23536@debbugs.gnu.org; Sat, 14 May 2016 04:50:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b1VGj-0004hR-5B for 23536@debbugs.gnu.org; Sat, 14 May 2016 04:49:56 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1VGj-0004hJ-2R; Sat, 14 May 2016 04:49:53 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1520 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b1VGh-0008FX-5a; Sat, 14 May 2016 04:49:51 -0400 In-reply-to: (message from Jim Meyering on Fri, 13 May 2016 22:31:38 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118234 Archived-At: > From: Jim Meyering > Date: Fri, 13 May 2016 22:31:38 -0700 > > This is using emacs commit (latest master) > c8109d9c4057d8cac79e2c139758cadd410e7446. > How to repro? > Invoke this: emacs -nw -Q -f viper-mode > Then answer "n" to the viperize prompt. > Type "/foo" and hit ENTER. > You'll notice that the minibuffer now contains this: > > ‘(default ) foo’: Pattern not found > > implying that you've searched for a string significantly different than "foo". > If you try again, you'll see that the search string grows even longer: > > ‘(default (default ) foo) foo’: Pattern not found > > It looks like this problem was introduced via commit > 088acab3831b45e0e0749705226b8680076df4b6, since > if I revert that and rebuild, the problem goes away. Please see if the patch below fixes the problem, and doesn't bring new ones. (I don't use viper-mode, and we don't have a test suite for it, so I couldn't easily test the result beyond your simple recipe.) Thanks. diff --git a/lisp/emulation/viper-cmd.el b/lisp/emulation/viper-cmd.el index da72b97..6951dbb 100644 --- a/lisp/emulation/viper-cmd.el +++ b/lisp/emulation/viper-cmd.el @@ -2127,6 +2127,7 @@ viper-read-string-with-history (setq keymap (or keymap minibuffer-local-map) initial (or initial "") + viper-initial initial temp-msg (if default (format "(default %s) " default) ""))