From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!) Date: Sun, 07 Aug 2016 17:12:18 +0300 Message-ID: <83y448is71.fsf@gnu.org> References: <25c2c856-ff1f-6e73-037a-65abae882673@live.com> <87lh0a7idu.fsf@users.sourceforge.net> <8337mil5pn.fsf@gnu.org> <83r3a2jie9.fsf@gnu.org> <83popmjga1.fsf@gnu.org> <87inve6q4y.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1470579207 6581 195.159.176.226 (7 Aug 2016 14:13:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 7 Aug 2016 14:13:27 +0000 (UTC) Cc: 24166@debbugs.gnu.org, clement.pitclaudel@live.com To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 07 16:13:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bWOpJ-0000W1-G7 for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Aug 2016 16:13:17 +0200 Original-Received: from localhost ([::1]:52843 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWOpG-0007si-8Q for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Aug 2016 10:13:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWOp9-0007iL-An for bug-gnu-emacs@gnu.org; Sun, 07 Aug 2016 10:13:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bWOp4-0003mk-7C for bug-gnu-emacs@gnu.org; Sun, 07 Aug 2016 10:13:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWOp4-0003mg-3V for bug-gnu-emacs@gnu.org; Sun, 07 Aug 2016 10:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bWOp3-0005hq-SM for bug-gnu-emacs@gnu.org; Sun, 07 Aug 2016 10:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Aug 2016 14:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24166 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24166-submit@debbugs.gnu.org id=B24166.147057915621903 (code B ref 24166); Sun, 07 Aug 2016 14:13:01 +0000 Original-Received: (at 24166) by debbugs.gnu.org; 7 Aug 2016 14:12:36 +0000 Original-Received: from localhost ([127.0.0.1]:59148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bWOod-0005hD-Oc for submit@debbugs.gnu.org; Sun, 07 Aug 2016 10:12:35 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bWOoc-0005h1-DA for 24166@debbugs.gnu.org; Sun, 07 Aug 2016 10:12:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bWOoW-0003l4-Hk for 24166@debbugs.gnu.org; Sun, 07 Aug 2016 10:12:29 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWOoR-0003kq-5V; Sun, 07 Aug 2016 10:12:23 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3445 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bWOoP-0004rT-Nj; Sun, 07 Aug 2016 10:12:22 -0400 In-reply-to: <87inve6q4y.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121943 Archived-At: > From: npostavs@users.sourceforge.net > Cc: 24166@debbugs.gnu.org, clement.pitclaudel@live.com > Date: Sat, 06 Aug 2016 08:25:17 -0400 > > Here's the new patch. Thanks. I have one minor comment below. > Is it correct to put the DEFSYM next to the DEFVAR_LISP? It isn't incorrect, and even eval.c already does that. > + /* If we are debugging an error within a call to `string-match-p', > + then make sure debugger code can still use match data. */ Please mention in the comment that string-match-p binds inhibit-changing-match-data, and that it is only one example of that. Otherwise, LGTM, thanks.