From: Eli Zaretskii <eliz@gnu.org>
To: npostavs@users.sourceforge.net
Cc: 24166@debbugs.gnu.org, clement.pitclaudel@live.com
Subject: bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!)
Date: Sun, 07 Aug 2016 17:12:18 +0300 [thread overview]
Message-ID: <83y448is71.fsf@gnu.org> (raw)
In-Reply-To: <87inve6q4y.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net)
> From: npostavs@users.sourceforge.net
> Cc: 24166@debbugs.gnu.org, clement.pitclaudel@live.com
> Date: Sat, 06 Aug 2016 08:25:17 -0400
>
> Here's the new patch.
Thanks. I have one minor comment below.
> Is it correct to put the DEFSYM next to the DEFVAR_LISP?
It isn't incorrect, and even eval.c already does that.
> + /* If we are debugging an error within a call to `string-match-p',
> + then make sure debugger code can still use match data. */
Please mention in the comment that string-match-p binds
inhibit-changing-match-data, and that it is only one example of that.
Otherwise, LGTM, thanks.
next prev parent reply other threads:[~2016-08-07 14:12 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 1:56 bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!) Clément Pit--Claudel
2016-08-06 2:15 ` npostavs
2016-08-06 3:03 ` Clément Pit--Claudel
2016-08-06 7:25 ` Eli Zaretskii
2016-08-06 10:28 ` Noam Postavsky
2016-08-06 10:34 ` Eli Zaretskii
2016-08-06 10:49 ` Noam Postavsky
2016-08-06 11:19 ` Eli Zaretskii
2016-08-06 12:25 ` npostavs
2016-08-07 14:12 ` Eli Zaretskii [this message]
2016-08-07 14:27 ` npostavs
2016-07-11 20:12 ` bug#23949: 25.0.95; Regression in handling error caused by (string-match-p "." nil) Kaushal Modi
2016-07-12 12:29 ` Kaushal Modi
2016-07-12 13:14 ` Eli Zaretskii
2016-07-12 13:33 ` Kaushal Modi
2016-07-12 13:37 ` Kaushal Modi
2016-07-12 14:03 ` Eli Zaretskii
2016-07-12 14:01 ` Eli Zaretskii
2016-07-12 18:35 ` Kaushal Modi
2016-07-12 18:55 ` Noam Postavsky
2016-07-12 19:00 ` Kaushal Modi
2016-07-12 19:12 ` Eli Zaretskii
2016-07-12 19:10 ` Eli Zaretskii
2016-07-12 19:19 ` Eli Zaretskii
2016-07-12 19:29 ` Kaushal Modi
2016-07-12 20:27 ` Stefan Monnier
2016-07-13 13:10 ` Kaushal Modi
2016-07-13 13:59 ` Stefan Monnier
2016-07-13 15:06 ` Eli Zaretskii
2016-07-13 15:03 ` Eli Zaretskii
2016-07-13 14:24 ` Eli Zaretskii
2016-07-13 14:48 ` Stefan Monnier
2016-07-13 15:14 ` Eli Zaretskii
2016-07-13 16:00 ` Stefan Monnier
2016-07-13 16:18 ` Eli Zaretskii
2016-07-13 16:41 ` Stefan Monnier
2016-07-13 15:03 ` Andreas Schwab
2016-07-13 15:17 ` Eli Zaretskii
2016-07-12 14:15 ` Andreas Schwab
[not found] ` <handler.23949.C.147058007223290.notifdonectrl.2@debbugs.gnu.org>
2016-08-09 15:56 ` bug#23949: acknowledged by developer (Re: bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!)) Kaushal Modi
2016-08-07 15:43 ` bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!) Clément Pit--Claudel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y448is71.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24166@debbugs.gnu.org \
--cc=clement.pitclaudel@live.com \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.