From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24206: 25.1; Curly quotes generate invalid strings, leading to a segfault Date: Sun, 14 Aug 2016 20:21:43 +0300 Message-ID: <83y43zfeqg.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1471195399 8905 195.159.176.226 (14 Aug 2016 17:23:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 14 Aug 2016 17:23:19 +0000 (UTC) Cc: p.stephani2@gmail.com, johnw@gnu.org, nicolas@petton.fr, 24206@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 14 19:23:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYz7y-000272-QV for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Aug 2016 19:23:14 +0200 Original-Received: from localhost ([::1]:33267 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYz7v-0002rK-QF for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Aug 2016 13:23:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYz7q-0002pn-O3 for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2016 13:23:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYz7m-0005gf-Dp for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2016 13:23:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYz7m-0005gb-AV for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2016 13:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bYz7m-0004F1-6r for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2016 13:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Aug 2016 17:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24206-submit@debbugs.gnu.org id=B24206.147119534816244 (code B ref 24206); Sun, 14 Aug 2016 17:23:02 +0000 Original-Received: (at 24206) by debbugs.gnu.org; 14 Aug 2016 17:22:28 +0000 Original-Received: from localhost ([127.0.0.1]:57442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYz7E-0004Dw-4r for submit@debbugs.gnu.org; Sun, 14 Aug 2016 13:22:28 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34651) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYz7C-0004Dh-F9 for 24206@debbugs.gnu.org; Sun, 14 Aug 2016 13:22:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYz74-0005Yp-7e for 24206@debbugs.gnu.org; Sun, 14 Aug 2016 13:22:21 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51057) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYz6s-0005Ua-1a; Sun, 14 Aug 2016 13:22:06 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1357 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bYz6n-0002Vz-RW; Sun, 14 Aug 2016 13:22:04 -0400 In-reply-to: (message from Paul Eggert on Sat, 13 Aug 2016 23:54:43 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122205 Archived-At: > Cc: 24206-done@debbugs.gnu.org, Eli Zaretskii , > John Wiegley , Nicolas Petton > From: Paul Eggert > Date: Sat, 13 Aug 2016 23:54:43 -0500 > > For Emacs 25 I propose installing the attached patch, which should avoid > the emacs-goodies-el problem though it does not fix the other > (presumably less-likely) bugs in this area. This patch is considerably > simpler than what I just installed into master. Paul, would you agree with the following alternative patch for the release branch? Phil, is the recipe you presented in this bug _exactly_ what emacs-goodies-el does? If not, could you please see if the proposed patch below fixes the real-life use case as well, and if not, show that use case? TIA. diff --git a/src/doc.c b/src/doc.c index 7cdb0d0..bba30b4 100644 --- a/src/doc.c +++ b/src/doc.c @@ -965,7 +965,8 @@ Otherwise, return a new string. */) } } else if ((strp[0] == '`' || strp[0] == '\'') - && quoting_style == CURVE_QUOTING_STYLE) + && quoting_style == CURVE_QUOTING_STYLE + && multibyte) { start = (unsigned char const *) (strp[0] == '`' ? uLSQM : uRSQM); length = 1;