From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25338: [PATCH] Remove local variable with only one usage Date: Sat, 07 Jan 2017 10:26:30 +0200 Message-ID: <83y3ynb7ih.fsf@gnu.org> References: <87eg0lcet2.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1483777636 28027 195.159.176.226 (7 Jan 2017 08:27:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Jan 2017 08:27:16 +0000 (UTC) Cc: 25338@debbugs.gnu.org To: Chris Gregory Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 07 09:27:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPmLD-0006A8-Kg for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jan 2017 09:27:07 +0100 Original-Received: from localhost ([::1]:56446 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPmLH-0006GE-Rw for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jan 2017 03:27:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPmLC-0006FJ-Hy for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 03:27:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPmL8-0007Hp-L7 for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 03:27:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58402) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cPmL8-0007Hj-Hk for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 03:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cPmL8-00089I-9L for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 03:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jan 2017 08:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25338 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25338-submit@debbugs.gnu.org id=B25338.148377759031279 (code B ref 25338); Sat, 07 Jan 2017 08:27:02 +0000 Original-Received: (at 25338) by debbugs.gnu.org; 7 Jan 2017 08:26:30 +0000 Original-Received: from localhost ([127.0.0.1]:45568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPmKb-00088Q-MI for submit@debbugs.gnu.org; Sat, 07 Jan 2017 03:26:29 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPmKa-00088B-KK for 25338@debbugs.gnu.org; Sat, 07 Jan 2017 03:26:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPmKR-00073J-LT for 25338@debbugs.gnu.org; Sat, 07 Jan 2017 03:26:23 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPmKH-00072q-VF; Sat, 07 Jan 2017 03:26:09 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1972 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cPmKG-0006FL-QV; Sat, 07 Jan 2017 03:26:09 -0500 In-reply-to: <87eg0lcet2.fsf@gmail.com> (message from Chris Gregory on Mon, 02 Jan 2017 13:50:01 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127868 Archived-At: tags 25338 notabug close 25338 thanks > From: Chris Gregory > Date: Mon, 02 Jan 2017 13:50:01 -0800 Thanks. IMO, we are splitting hair here. In an optimized build, a compiler will optimize 'str' and keep the value in a register, so the variable doesn't matter. In a non-optimized build, the existence of the variable allows to look at it in a debugger. And the loop is small enough so that an extra variable local to the loop doesn't make it more complicated. So I'd rather not make this change.