all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Chris Gregory <czipperz@gmail.com>
Cc: 25338@debbugs.gnu.org
Subject: bug#25338: [PATCH] Remove local variable with only one usage
Date: Sat, 07 Jan 2017 10:26:30 +0200	[thread overview]
Message-ID: <83y3ynb7ih.fsf@gnu.org> (raw)
In-Reply-To: <87eg0lcet2.fsf@gmail.com> (message from Chris Gregory on Mon, 02 Jan 2017 13:50:01 -0800)

tags 25338 notabug
close 25338
thanks

> From: Chris Gregory <czipperz@gmail.com>
> Date: Mon, 02 Jan 2017 13:50:01 -0800

Thanks.

IMO, we are splitting hair here.  In an optimized build, a compiler
will optimize 'str' and keep the value in a register, so the variable
doesn't matter.  In a non-optimized build, the existence of the
variable allows to look at it in a debugger.  And the loop is small
enough so that an extra variable local to the loop doesn't make it
more complicated.

So I'd rather not make this change.





      reply	other threads:[~2017-01-07  8:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 21:50 bug#25338: [PATCH] Remove local variable with only one usage Chris Gregory
2017-01-07  8:26 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y3ynb7ih.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=25338@debbugs.gnu.org \
    --cc=czipperz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.