From: Eli Zaretskii <eliz@gnu.org>
To: charles@aurox.ch (Charles A. Roelli)
Cc: 25773@debbugs.gnu.org
Subject: bug#25773: 25.2; movement w/ prefix args in rectangle-mark-mode
Date: Fri, 17 Feb 2017 17:00:24 +0200 [thread overview]
Message-ID: <83y3x4rhfb.fsf@gnu.org> (raw)
In-Reply-To: <m2tw7sncq3.fsf@aurox.ch> (charles@aurox.ch)
> From: charles@aurox.ch (Charles A. Roelli)
> Date: Fri, 17 Feb 2017 14:55:32 +0100
>
> >From emacs -Q:
>
> - C-u 2 C-p
> - C-x SPC
> - C-u C-f
>
> Emacs hangs before point can move, and you can exit the hang with enough
> C-g's. C-f works fine without a prefix arg, however.
(It also works with a prefix arg, as long as the arg is 1.)
Does the patch below give good results? (I myself am not much of a
rectangle-mode user.)
Thanks.
diff --git a/lisp/rect.el b/lisp/rect.el
index a4fa282..a85101f 100644
--- a/lisp/rect.el
+++ b/lisp/rect.el
@@ -639,7 +639,8 @@ rectangle--*-char
;; rectangles" and not "visual rectangles", so in the presence of
;; bidirectional text things won't work well anyway.
(if (< n 0) (rectangle--*-char other-cmd (- n))
- (let ((col (rectangle--point-col (point))))
+ (let ((col (rectangle--point-col (point)))
+ (step 1))
(while (> n 0)
(let* ((bol (line-beginning-position))
(eol (line-end-position))
@@ -647,7 +648,7 @@ rectangle--*-char
(nextcol
(condition-case nil
(save-excursion
- (funcall cmd 1)
+ (funcall cmd step)
(cond
((> bol (point)) (- curcol 1))
((< eol (point)) (+ col (1+ n)))
@@ -666,7 +667,8 @@ rectangle--*-char
(t ;; (> nextcol curcol)
(if (<= diff n)
(progn (cl-decf n diff) (setq col nextcol))
- (setq col (if (< col nextcol) (+ col n) (- col n)) n 0))))))
+ (setq col (if (< col nextcol) (+ col n) (- col n)) n 0))))
+ (setq step (1+ step))))
;; FIXME: This rectangle--col-pos's move-to-column is wasted!
(rectangle--col-pos col 'point))))
next prev parent reply other threads:[~2017-02-17 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 13:55 bug#25773: 25.2; movement w/ prefix args in rectangle-mark-mode Charles A. Roelli
2017-02-17 15:00 ` Eli Zaretskii [this message]
2017-02-17 16:39 ` Charles A. Roelli
2017-02-18 9:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y3x4rhfb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=25773@debbugs.gnu.org \
--cc=charles@aurox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.