bug#25911: Subject: 26.0.50; Defun apply-partially is in 'Basic Lisp macros'

bug#25911: Subject: 26.0.50; Defun apply-partially is in 'Basic Lisp macros'

[Tino Calancha]

We might move its definition into 'Basic Lisp functions'.

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
From 3b4254f7a37c4dc8418e9a03e91cd233a4180e10 Mon Sep 17 00:00:00 2001
From: Tino Calancha <tino.calancha@gmail.com>
Date: Wed, 1 Mar 2017 17:30:52 +0900
Subject: [PATCH] * lisp/subr.el (apply-partially): Move to 'Basic Lisp
 functions' section.

---
 lisp/subr.el | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/lisp/subr.el b/lisp/subr.el
index 4f848d1400..6b0403890c 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -132,15 +132,6 @@ defvar-local
   (list 'progn (list 'defvar var val docstring)
         (list 'make-variable-buffer-local (list 'quote var))))
 
-(defun apply-partially (fun &rest args)
-  "Return a function that is a partial application of FUN to ARGS.
-ARGS is a list of the first N arguments to pass to FUN.
-The result is a new function which does the same as FUN, except that
-the first N arguments are fixed at the values with which this function
-was called."
-  (lambda (&rest args2)
-    (apply fun (append args args2))))
-
 (defmacro push (newelt place)
   "Add NEWELT to the list stored in the generalized variable PLACE.
 This is morally equivalent to (setf PLACE (cons NEWELT PLACE)),
@@ -344,6 +335,15 @@ frame-configuration-p
   (and (consp object)
        (eq (car object) 'frame-configuration)))
 
+(defun apply-partially (fun &rest args)
+  "Return a function that is a partial application of FUN to ARGS.
+ARGS is a list of the first N arguments to pass to FUN.
+The result is a new function which does the same as FUN, except that
+the first N arguments are fixed at the values with which this function
+was called."
+  (lambda (&rest args2)
+    (apply fun (append args args2))))
+
 \f
 ;;;; List functions.
 
-- 
2.11.0



;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.8)
 of 2017-03-01
Repository revision: 03f64ebbc685d803f9dcbb638c37501e0d6f8340

bug#25911: Subject: 26.0.50; Defun apply-partially is in 'Basic Lisp macros'

[Eli Zaretskii]

> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Wed, 01 Mar 2017 17:35:31 +0900
> 
> We might move its definition into 'Basic Lisp functions'.

Can you tell why?

Thanks.

bug#25911: Subject: 26.0.50; Defun apply-partially is in 'Basic Lisp macros'

[Glenn Morris]

Eli Zaretskii wrote:

>> We might move its definition into 'Basic Lisp functions'.
>
> Can you tell why?

Presumably because it's a function, not a macro.

bug#25911: Subject: 26.0.50; Defun apply-partially is in 'Basic Lisp macros'

[Glenn Morris]

PS why even make a bug report for this? Either ignore it or change it.

bug#25911: Subject: 26.0.50; Defun apply-partially is in 'Basic Lisp macros'

[Tino Calancha]

On Wed, 1 Mar 2017, Glenn Morris wrote:

> Eli Zaretskii wrote:
>
>>> We might move its definition into 'Basic Lisp functions'.
>>
>> Can you tell why?
>
> Presumably because it's a function, not a macro.
Yes, that's the reason.

bug#25911: Subject: 26.0.50; Defun apply-partially is in 'Basic Lisp macros'

[Tino Calancha]

On Wed, 1 Mar 2017, Glenn Morris wrote:

>
> PS why even make a bug report for this? Either ignore it or change it.
To get suggestion about the proper branch where to do the change:
Emacs-25 or master

bug#25911: Subject: 26.0.50; Defun apply-partially is in 'Basic Lisp macros'

[Eli Zaretskii]

> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Thu, 2 Mar 2017 09:28:41 +0900 (JST)
> cc: Eli Zaretskii <eliz@gnu.org>, Tino Calancha <tino.calancha@gmail.com>, 
>     25911@debbugs.gnu.org
> 
> On Wed, 1 Mar 2017, Glenn Morris wrote:
> 
> > Eli Zaretskii wrote:
> >
> >>> We might move its definition into 'Basic Lisp functions'.
> >>
> >> Can you tell why?
> >
> > Presumably because it's a function, not a macro.
> Yes, that's the reason.

Fine with me.  (I don't know why Stefan put it in that particular
place when he moved it from simple.el.)

bug#25911: Subject: 26.0.50; Defun apply-partially is in 'Basic Lisp macros'

[Eli Zaretskii]

> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Thu, 2 Mar 2017 09:29:39 +0900 (JST)
> cc: 25911@debbugs.gnu.org, Tino Calancha <tino.calancha@gmail.com>, 
>     Eli Zaretskii <eliz@gnu.org>
> 
> On Wed, 1 Mar 2017, Glenn Morris wrote:
> 
> >
> > PS why even make a bug report for this? Either ignore it or change it.
> To get suggestion about the proper branch where to do the change:
> Emacs-25 or master

Master, of course.

Thanks.

bug#25911: Subject: 26.0.50; Defun apply-partially is in 'Basic Lisp macros'

[Tino Calancha]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Tino Calancha <tino.calancha@gmail.com>
>> Date: Thu, 2 Mar 2017 09:28:41 +0900 (JST)
>> cc: Eli Zaretskii <eliz@gnu.org>, Tino Calancha <tino.calancha@gmail.com>, 
>>     25911@debbugs.gnu.org
>> 
>> On Wed, 1 Mar 2017, Glenn Morris wrote:
>> 
>> > Eli Zaretskii wrote:
>> >
>> >>> We might move its definition into 'Basic Lisp functions'.
>> >>
>> >> Can you tell why?
>> >
>> > Presumably because it's a function, not a macro.
>> Yes, that's the reason.
>
> Fine with me.  (I don't know why Stefan put it in that particular
> place when he moved it from simple.el.)

>> > PS why even make a bug report for this? Either ignore it or change it.
>> To get suggestion about the proper branch where to do the change:
>> Emacs-25 or master

>Master, of course.
Thanks for the clarification.
Pushed to master as commit 6a9ba271a956127e566192b33fc811e802d2d475