From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25945: Emacs aborts while calling FT_Load_Glyph Date: Tue, 11 Apr 2017 13:08:08 +0300 Message-ID: <83y3v7jlyv.fsf@gnu.org> References: <20170303.080429.592950574985497052.wl@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1491905355 11502 195.159.176.226 (11 Apr 2017 10:09:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 11 Apr 2017 10:09:15 +0000 (UTC) Cc: 25945-done@debbugs.gnu.org To: Werner LEMBERG Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 11 12:09:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cxsjX-0002t3-1E for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Apr 2017 12:09:11 +0200 Original-Received: from localhost ([::1]:38275 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxsjb-0007jx-DP for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Apr 2017 06:09:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxsjR-0007iv-7h for bug-gnu-emacs@gnu.org; Tue, 11 Apr 2017 06:09:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cxsjO-0002Re-4X for bug-gnu-emacs@gnu.org; Tue, 11 Apr 2017 06:09:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43797) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cxsjO-0002RP-0n for bug-gnu-emacs@gnu.org; Tue, 11 Apr 2017 06:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cxsjN-0007jE-RX for bug-gnu-emacs@gnu.org; Tue, 11 Apr 2017 06:09:01 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Apr 2017 10:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 25945 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 25945@debbugs.gnu.org, eliz@gnu.org, wl@gnu.org Original-Received: via spool by 25945-done@debbugs.gnu.org id=D25945.149190528529633 (code D ref 25945); Tue, 11 Apr 2017 10:09:01 +0000 Original-Received: (at 25945-done) by debbugs.gnu.org; 11 Apr 2017 10:08:05 +0000 Original-Received: from localhost ([127.0.0.1]:41995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cxsiS-0007ht-TG for submit@debbugs.gnu.org; Tue, 11 Apr 2017 06:08:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cxsiR-0007hM-K7 for 25945-done@debbugs.gnu.org; Tue, 11 Apr 2017 06:08:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cxsiL-0002BF-EN for 25945-done@debbugs.gnu.org; Tue, 11 Apr 2017 06:07:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53057) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxsiG-00029p-DA; Tue, 11 Apr 2017 06:07:52 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4978 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cxsiF-0006si-Oq; Tue, 11 Apr 2017 06:07:52 -0400 In-reply-to: <20170303.080429.592950574985497052.wl@gnu.org> (message from Werner LEMBERG on Fri, 03 Mar 2017 08:04:29 +0100 (CET)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131465 Archived-At: > Date: Fri, 03 Mar 2017 08:04:29 +0100 (CET) > From: Werner LEMBERG > > For me, Emacs aborts at ftfont.c:1550 while `mew' tries to display an > e-mail. > > 1549 if (FT_Load_Glyph (ft_face, g->g.code, FT_LOAD_DEFAULT) != 0) > 1550 emacs_abort (); > > Examining `ft_face' and `g->g.code' I see that the font in question is > `Padauk Book Bold' (PadaukBook-Bold.ttf), glyph 376. Examining this > font further with `ftview' I see that bytecode of this font is broken, > and that the font can only be displayed successfully without bytecode. > [This is version 3.002 of the font, taken from the current TeXLive > repository.] > > I think there is no reason that Emacs aborts for such broken fonts. > Instead I suggest that (a) Emacs tries to load the glyph again without > hinting, and (b) if that fails, it should display a missing glyph, > using the standard rectangle with hex digits in it. > > New code for (a) is quite simple: > > if (FT_Load_Glyph (ft_face, g->g.code, FT_LOAD_DEFAULT) != 0) > if (FT_Load_Glyph (ft_face, g->g.code, FT_LOAD_NO_HINTING) != 0) > ... Thanks, I've now pushed this change to the Emacs master branch, and I'm marking this bug done.