From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: package.el strings Date: Sat, 15 Jul 2017 15:52:23 +0300 Message-ID: <83y3rpeubc.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1500123183 27670 195.159.176.226 (15 Jul 2017 12:53:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 15 Jul 2017 12:53:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jean-Christophe Helary Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 15 14:52:59 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWMZ8-00070j-Bq for ged-emacs-devel@m.gmane.org; Sat, 15 Jul 2017 14:52:58 +0200 Original-Received: from localhost ([::1]:42046 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWMZD-0003pE-Uy for ged-emacs-devel@m.gmane.org; Sat, 15 Jul 2017 08:53:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWMYa-0003p9-FE for emacs-devel@gnu.org; Sat, 15 Jul 2017 08:52:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWMYV-00058U-Jw for emacs-devel@gnu.org; Sat, 15 Jul 2017 08:52:24 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWMYV-00058L-Fn; Sat, 15 Jul 2017 08:52:19 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1726 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dWMYU-00024L-Sm; Sat, 15 Jul 2017 08:52:19 -0400 In-reply-to: (message from Jean-Christophe Helary on Fri, 14 Jul 2017 11:53:51 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216682 Archived-At: > From: Jean-Christophe Helary > Date: Fri, 14 Jul 2017 11:53:51 +0900 > > It took me a lot longer than I thought but here is a diff for your comments. There is a dozen modifications in the file and a few comments. Thanks for working in this. I have a few comments: > @@ -1490,7 +1492,7 @@ package-import-keyring > (setf (epg-context-home-directory context) package-gnupghome-dir)) > (message "Importing %s..." (file-name-nondirectory file)) > (epg-import-keys-from-file context file) > - (message "Importing %s...done" (file-name-nondirectory file)))) > + (message "Importing %s... Done" (file-name-nondirectory file)))) Can you tell why this is needed? The current code is how we say this in a lot of places, and I don't think I see why it's bad for l10n. > - (format "%s packages will be installed:\n%s, proceed?" > + (format "Number of packages to install: %s (%s), proceed? " > (length available) > - (mapconcat #'symbol-name available ", "))) > + (mapconcat #'symbol-name available " "))) You've removed the newline, so the prompt will wrap at some random place. Is it really a good idea? Also, I'd lose the "Number" part, and use %d for format, so it's clear to translators that a number will follow. > - (message "%s packages are not available (the rest already installed), maybe you need to `M-x package-refresh-contents'" > + (message "Number of packages that are not available: %s (the rest is already installed), maybe you need to `M-x package-refresh-contents'" Likewise here: I'd say "Packages not available: %d". Same issue with some other replacements you propose. > - (format "%s packages will be deleted:\n%s, proceed? " > + (format "Number of packages to delete: %s (%s), proceed? " > (length removable) > - (mapconcat #'symbol-name removable ", "))) > + (mapconcat #'symbol-name removable " "))) And here. > - (prin1 name) > - (princ " is ") > - (princ (if (memq (aref status 0) '(?a ?e ?i ?o ?u)) "an " "a ")) > - (princ status) > - (princ " package.\n\n") > + (let ((sentence (format "The status of package %S is `%s'.\n\n" name status))) > + (princ sentence)) Too wordy for my liking. How about this: (princ (format "Package %S is %s.\n\n" name status)) > - (concat > - (when delete "Delete ") > - (package-menu--list-to-prompt delete) > - (when (and delete install) > - (if upgrade "; " "; and ")) > - (when install "Install ") > - (package-menu--list-to-prompt install) > - (when (and upgrade (or install delete)) "; and ") > - (when upgrade "Upgrade ") > - (package-menu--list-to-prompt upgrade) > - "? "))) > + (format "Number of packages to delete: %s / install: %s / upgrade: %s, proceed? " > + (package-menu--list-to-prompt delete) > + (package-menu--list-to-prompt install) > + (package-menu--list-to-prompt upgrade)))) This loses the feature of saying just what's needed, instead of showing zero. Can we do better?