From: Eli Zaretskii <eliz@gnu.org>
To: Jean-Christophe Helary <jean.christophe.helary@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: package.el strings
Date: Sat, 15 Jul 2017 15:52:23 +0300 [thread overview]
Message-ID: <83y3rpeubc.fsf@gnu.org> (raw)
In-Reply-To: <F0133918-849D-4C5D-8BCD-3001FB3B68F5@gmail.com> (message from Jean-Christophe Helary on Fri, 14 Jul 2017 11:53:51 +0900)
> From: Jean-Christophe Helary <jean.christophe.helary@gmail.com>
> Date: Fri, 14 Jul 2017 11:53:51 +0900
>
> It took me a lot longer than I thought but here is a diff for your comments. There is a dozen modifications in the file and a few comments.
Thanks for working in this. I have a few comments:
> @@ -1490,7 +1492,7 @@ package-import-keyring
> (setf (epg-context-home-directory context) package-gnupghome-dir))
> (message "Importing %s..." (file-name-nondirectory file))
> (epg-import-keys-from-file context file)
> - (message "Importing %s...done" (file-name-nondirectory file))))
> + (message "Importing %s... Done" (file-name-nondirectory file))))
Can you tell why this is needed? The current code is how we say this
in a lot of places, and I don't think I see why it's bad for l10n.
> - (format "%s packages will be installed:\n%s, proceed?"
> + (format "Number of packages to install: %s (%s), proceed? "
> (length available)
> - (mapconcat #'symbol-name available ", ")))
> + (mapconcat #'symbol-name available " ")))
You've removed the newline, so the prompt will wrap at some random
place. Is it really a good idea?
Also, I'd lose the "Number" part, and use %d for format, so it's clear
to translators that a number will follow.
> - (message "%s packages are not available (the rest already installed), maybe you need to `M-x package-refresh-contents'"
> + (message "Number of packages that are not available: %s (the rest is already installed), maybe you need to `M-x package-refresh-contents'"
Likewise here: I'd say "Packages not available: %d". Same issue with
some other replacements you propose.
> - (format "%s packages will be deleted:\n%s, proceed? "
> + (format "Number of packages to delete: %s (%s), proceed? "
> (length removable)
> - (mapconcat #'symbol-name removable ", ")))
> + (mapconcat #'symbol-name removable " ")))
And here.
> - (prin1 name)
> - (princ " is ")
> - (princ (if (memq (aref status 0) '(?a ?e ?i ?o ?u)) "an " "a "))
> - (princ status)
> - (princ " package.\n\n")
> + (let ((sentence (format "The status of package %S is `%s'.\n\n" name status)))
> + (princ sentence))
Too wordy for my liking. How about this:
(princ (format "Package %S is %s.\n\n" name status))
> - (concat
> - (when delete "Delete ")
> - (package-menu--list-to-prompt delete)
> - (when (and delete install)
> - (if upgrade "; " "; and "))
> - (when install "Install ")
> - (package-menu--list-to-prompt install)
> - (when (and upgrade (or install delete)) "; and ")
> - (when upgrade "Upgrade ")
> - (package-menu--list-to-prompt upgrade)
> - "? ")))
> + (format "Number of packages to delete: %s / install: %s / upgrade: %s, proceed? "
> + (package-menu--list-to-prompt delete)
> + (package-menu--list-to-prompt install)
> + (package-menu--list-to-prompt upgrade))))
This loses the feature of saying just what's needed, instead of
showing zero. Can we do better?
next prev parent reply other threads:[~2017-07-15 12:52 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 5:08 package.el strings Jean-Christophe Helary
2017-05-24 11:00 ` Jean-Christophe Helary
2017-05-24 12:04 ` Dmitry Gutov
2017-05-24 12:07 ` Jean-Christophe Helary
2017-05-24 12:36 ` Yuri Khan
2017-05-24 14:16 ` Richard Stallman
2017-07-14 2:53 ` Jean-Christophe Helary
2017-07-15 12:52 ` Eli Zaretskii [this message]
2017-07-15 14:48 ` Jean-Christophe Helary
2017-07-16 13:55 ` Jean-Christophe Helary
2017-07-16 14:16 ` Eli Zaretskii
2017-07-16 14:35 ` Eli Zaretskii
2017-07-16 14:37 ` Jean-Christophe Helary
2017-07-17 15:28 ` Jean-Christophe Helary
2017-07-22 9:23 ` Eli Zaretskii
2018-04-18 6:38 ` Jean-Christophe Helary
2018-04-26 1:10 ` Noam Postavsky
2018-04-26 6:31 ` Jean-Christophe Helary
2018-04-26 11:28 ` Noam Postavsky
2018-04-26 13:32 ` Jean-Christophe Helary
2018-04-28 22:11 ` Noam Postavsky
2018-04-28 23:46 ` Jean-Christophe Helary
2018-05-29 22:38 ` Noam Postavsky
2018-05-29 22:46 ` Jean-Christophe Helary
2018-06-17 14:02 ` Jean-Christophe Helary
2018-06-17 14:33 ` Eli Zaretskii
2018-06-17 14:45 ` Jean-Christophe Helary
2018-06-17 14:50 ` Eli Zaretskii
2018-06-17 14:58 ` Jean-Christophe Helary
2018-06-20 13:53 ` Jean-Christophe Helary
2018-06-20 15:54 ` Eli Zaretskii
2018-06-20 16:19 ` Jean-Christophe Helary
2018-06-24 15:37 ` Noam Postavsky
2018-06-24 21:57 ` Jean-Christophe Helary
2018-06-24 23:09 ` Noam Postavsky
2018-06-25 1:39 ` Jean-Christophe Helary
2018-06-25 23:22 ` Noam Postavsky
2018-06-27 4:21 ` Jean-Christophe Helary
2018-06-27 18:32 ` Noam Postavsky
2018-04-29 19:43 ` Stefan Monnier
2018-04-26 13:40 ` Jean-Christophe Helary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y3rpeubc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jean.christophe.helary@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.