From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Native line numbers landed on master Date: Sat, 22 Jul 2017 12:18:49 +0300 Message-ID: <83y3rg96di.fsf@gnu.org> References: <83k23jl5ra.fsf@gnu.org> <87r2xqo8p7.fsf@lylat> <83lgnxk7v6.fsf@gnu.org> <87shi5jk2w.fsf@lylat> <83lgnwi3k3.fsf@gnu.org> <87a84crq31.fsf@lylat> <834lujj9d5.fsf@gnu.org> <87pod67lgi.fsf@lylat> <83fue1iur9.fsf@gnu.org> <87d190j0tz.fsf@lylat> <83h8yceal3.fsf@gnu.org> <871spgrxef.fsf@lylat> <83poczcdlz.fsf@gnu.org> <87pocyiz06.fsf@lylat> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1500715149 30367 195.159.176.226 (22 Jul 2017 09:19:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Jul 2017 09:19:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alex Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 22 11:19:06 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYqYz-0007fL-FV for ged-emacs-devel@m.gmane.org; Sat, 22 Jul 2017 11:19:05 +0200 Original-Received: from localhost ([::1]:46223 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYqZ5-0004py-6l for ged-emacs-devel@m.gmane.org; Sat, 22 Jul 2017 05:19:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYqYr-0004oS-NG for emacs-devel@gnu.org; Sat, 22 Jul 2017 05:18:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYqYo-0008RD-JG for emacs-devel@gnu.org; Sat, 22 Jul 2017 05:18:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYqYo-0008Qt-Gk; Sat, 22 Jul 2017 05:18:54 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3404 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dYqYn-0004P3-VT; Sat, 22 Jul 2017 05:18:54 -0400 In-reply-to: <87pocyiz06.fsf@lylat> (message from Alex on Mon, 17 Jul 2017 14:34:17 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216932 Archived-At: > From: Alex > Cc: emacs-devel@gnu.org > Date: Mon, 17 Jul 2017 14:34:17 -0600 > > >> > All else being equal, I think having as much as possible in > >> > display-line-numbers.el would be better, as it avoids scattering > >> > related stuff across different files. > >> > >> I agree. Here's an updated patch that includes this as well as other > >> improvements: > > > > LGTM, thanks. How about updating the manual and NEWS as well? > > Sure, I've done that in [1]. I've also fixed a DEFSYM issue that was > caused by the rename from display-line-number-width to > display-line-numbers-width in patch [2] Thanks, I pushed this and the previous patch to the master branch.