From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29557: lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID? Date: Mon, 04 Dec 2017 17:45:26 +0200 Message-ID: <83y3mixzs9.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1512402375 27980 195.159.176.226 (4 Dec 2017 15:46:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 4 Dec 2017 15:46:15 +0000 (UTC) Cc: 29557-done@debbugs.gnu.org To: Keith David Bershatsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 04 16:46:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLswa-0006sg-96 for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Dec 2017 16:46:08 +0100 Original-Received: from localhost ([::1]:43807 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLswh-0006bO-Iw for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Dec 2017 10:46:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLswb-0006aP-GR for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2017 10:46:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLswV-0002YZ-ND for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2017 10:46:09 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36971) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eLswV-0002YT-JU for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2017 10:46:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eLswV-000353-AW for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2017 10:46:03 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Dec 2017 15:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 29557 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 29557@debbugs.gnu.org, eliz@gnu.org, esq@lawlist.com Original-Received: via spool by 29557-done@debbugs.gnu.org id=D29557.151240235011059 (code D ref 29557); Mon, 04 Dec 2017 15:46:01 +0000 Original-Received: (at 29557-done) by debbugs.gnu.org; 4 Dec 2017 15:45:50 +0000 Original-Received: from localhost ([127.0.0.1]:45651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLswG-0002qA-Je for submit@debbugs.gnu.org; Mon, 04 Dec 2017 10:45:50 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLswF-0002i8-3G for 29557-done@debbugs.gnu.org; Mon, 04 Dec 2017 10:45:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLsw7-0002Cw-7j for 29557-done@debbugs.gnu.org; Mon, 04 Dec 2017 10:45:41 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLsw6-0002Cm-Tr; Mon, 04 Dec 2017 10:45:39 -0500 Original-Received: from [176.228.60.248] (port=4272 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eLsw6-0005LT-9x; Mon, 04 Dec 2017 10:45:38 -0500 In-reply-to: (message from Keith David Bershatsky on Sun, 03 Dec 2017 17:59:34 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140679 Archived-At: > Date: Sun, 03 Dec 2017 17:59:34 -0800 > From: Keith David Bershatsky > > I had assumed that VERTICAL_BORDER_FACE_ID was a basic face (see dispextern.h at line 1750). However, it is not identified as such within lookup_basic_face. Is this something that should be added? Without it, Emacs will throw an error if someone tries to look it up and its not there. Yes, it's an omission (and a very old one). Fixed on the master branch. Thanks for reporting this.