From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) Date: Thu, 18 Jan 2018 16:04:05 +0200 Message-ID: <83y3kvuuui.fsf@gnu.org> References: <20180117222846.93077-1-phst@google.com> <20180117222846.93077-2-phst@google.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1516284228 26411 195.159.176.226 (18 Jan 2018 14:03:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 Jan 2018 14:03:48 +0000 (UTC) Cc: phst@google.com, 30106@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 18 15:03:44 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecAmi-000591-VL for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jan 2018 15:03:17 +0100 Original-Received: from localhost ([::1]:32965 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecAoj-0001r0-0c for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jan 2018 09:05:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecAoW-0001o9-5O for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 09:05:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecAoQ-0002jO-Cl for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 09:05:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53203) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ecAoQ-0002jB-9x for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 09:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ecAoQ-00048t-1w for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 09:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jan 2018 14:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30106 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30106-submit@debbugs.gnu.org id=B30106.151628427215882 (code B ref 30106); Thu, 18 Jan 2018 14:05:01 +0000 Original-Received: (at 30106) by debbugs.gnu.org; 18 Jan 2018 14:04:32 +0000 Original-Received: from localhost ([127.0.0.1]:32867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecAnw-000485-Bm for submit@debbugs.gnu.org; Thu, 18 Jan 2018 09:04:32 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecAns-00047q-Fk for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 09:04:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecAnk-0001zS-L2 for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 09:04:23 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecAna-0001tK-E4; Thu, 18 Jan 2018 09:04:10 -0500 Original-Received: from [176.228.60.248] (port=3972 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ecAnZ-0001aT-Dg; Thu, 18 Jan 2018 09:04:09 -0500 In-reply-to: <20180117222846.93077-2-phst@google.com> (message from Philipp Stephani on Wed, 17 Jan 2018 23:28:46 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142250 Archived-At: > From: Philipp Stephani > Cc: Philipp Stephani > Date: Wed, 17 Jan 2018 23:28:46 +0100 > > * src/systhread.c (sys_thread_equal): New function. > * src/emacs-module.c (in_current_thread): Use it. I'd prefer that the only file that calls systhread.c functions is thread.c; systhread.c is supposed to be low-level code concealed from application levels. So this would call for another level of indirection: add a new function to thread.c, and call that from emacs-module.c. Otherwise, LGTM for master; thanks.