From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30855: 25.3; temacs fails with bus error during garbage collection Date: Tue, 20 Mar 2018 16:47:29 +0200 Message-ID: <83y3imls72.fsf@gnu.org> References: <23215.54774.152043.418244@a1i15.kph.uni-mainz.de> <834llboouy.fsf@gnu.org> <23217.5116.912173.630464@a1i15.kph.uni-mainz.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1521557181 4919 195.159.176.226 (20 Mar 2018 14:46:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Mar 2018 14:46:21 +0000 (UTC) Cc: 30855@debbugs.gnu.org, gentoo-bug@opensource.sf-tec.de To: Ulrich Mueller , Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 20 15:46:16 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyIWj-00015o-23 for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Mar 2018 15:46:13 +0100 Original-Received: from localhost ([::1]:49604 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyIYm-0007Fv-1L for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Mar 2018 10:48:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyIYY-0007Di-K6 for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 10:48:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyIYU-0003T1-Qc for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 10:48:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36061) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyIYU-0003Si-MI for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 10:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eyIYU-0003kM-D8 for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 10:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Mar 2018 14:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30855-submit@debbugs.gnu.org id=B30855.152155728014394 (code B ref 30855); Tue, 20 Mar 2018 14:48:02 +0000 Original-Received: (at 30855) by debbugs.gnu.org; 20 Mar 2018 14:48:00 +0000 Original-Received: from localhost ([127.0.0.1]:43958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyIYR-0003k6-TX for submit@debbugs.gnu.org; Tue, 20 Mar 2018 10:48:00 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyIYQ-0003jr-49 for 30855@debbugs.gnu.org; Tue, 20 Mar 2018 10:47:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyIYH-0003Ds-HX for 30855@debbugs.gnu.org; Tue, 20 Mar 2018 10:47:52 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyIXl-0002lh-KU; Tue, 20 Mar 2018 10:47:17 -0400 Original-Received: from [176.228.60.248] (port=4394 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eyIXl-00027V-2E; Tue, 20 Mar 2018 10:47:17 -0400 In-reply-to: <23217.5116.912173.630464@a1i15.kph.uni-mainz.de> (message from Ulrich Mueller on Tue, 20 Mar 2018 15:00:28 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144450 Archived-At: > Date: Tue, 20 Mar 2018 15:00:28 +0100 > Cc: 30855@debbugs.gnu.org, > gentoo-bug@opensource.sf-tec.de > From: Ulrich Mueller > > for (pp = start; (void *) pp < end; pp += GC_POINTER_ALIGNMENT) > { > mark_maybe_pointer (*(void **) pp); > mark_maybe_object (*(Lisp_Object *) pp); > } > > The loop is in steps of 4 but tries to access objects of size 8. So you are saying that we should be doing the below instead? diff --git a/src/alloc.c b/src/alloc.c index 9d0e2d3..18546ca 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -4983,7 +4983,8 @@ mark_memory (void *start, void *end) for (pp = start; (void *) pp < end; pp += GC_POINTER_ALIGNMENT) { mark_maybe_pointer (*(void **) pp); - mark_maybe_object (*(Lisp_Object *) pp); + if ((intptr_t) pp % GCALIGNMENT == 0) + mark_maybe_object (*(Lisp_Object *) pp); } }