all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 17250@debbugs.gnu.org
Subject: bug#17250: 24.3; find-variable gives search-failed error message
Date: Wed, 18 Apr 2018 09:23:40 +0300	[thread overview]
Message-ID: <83y3hl118z.fsf@gnu.org> (raw)
In-Reply-To: <87zi21e8yo.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Wed, 18 Apr 2018 00:58:39 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Wed, 18 Apr 2018 00:58:39 +0200
> Cc: 17250@debbugs.gnu.org
> 
> But there are several places that use this function without checking the
> return value.  Are they relying on this function to bug out with a
> cryptic error, or are they all confident that the file name can be
> found?
> 
> So I haven't applied it yet.  Perhaps somebody else will weigh in...

I'm not weighing in ;-)

>  (defun help-C-file-name (subr-or-var kind)
>    "Return the name of the C file where SUBR-OR-VAR is defined.
> -KIND should be `var' for a variable or `subr' for a subroutine."
> +KIND should be `var' for a variable or `subr' for a subroutine.
> +If we can't find the file name, nil is returned."
                                   ^^^^^^^^^^^^^^^
"return nil".  We try to avoid passive tense.





  reply	other threads:[~2018-04-18  6:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-12 12:38 bug#17250: 24.3; find-variable gives search-failed error message Johan Claesson
2018-04-17 22:58 ` Lars Ingebrigtsen
2018-04-18  6:23   ` Eli Zaretskii [this message]
2018-04-28  2:27   ` Noam Postavsky
2019-06-26 14:06     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y3hl118z.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=17250@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.