From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 32064@debbugs.gnu.org
Subject: bug#32064: 26; doc string of `eval-last-sexp'
Date: Fri, 06 Jul 2018 12:34:11 +0300 [thread overview]
Message-ID: <83y3eolncc.fsf@gnu.org> (raw)
In-Reply-To: <0d7bb132-057e-431e-a5fa-86e15b99879a@default> (message from Drew Adams on Thu, 5 Jul 2018 13:15:16 -0700 (PDT))
> Date: Thu, 5 Jul 2018 13:15:16 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
>
> The doc string was messed up a bit in Emacs 26, apparently for the fix
> of bug #4118.
It was also somewhat messed up in Emacs 25.
> 1. Do not truncate.
> 2. Print in additional formats.
>
> That's fine. But the Emacs 26+ version also says that with a ZERO prefix
> arg ("such a prefix argument"), if the prefix arg is ALSO -1
> (impossible) or if "the integer" (what integer?) is less than or equal
> to the value of `eval-expression-print-maximum-character', the
> additional formats include "character".
>
> A character is not a format, so it's unclear what printing in format
> "character" means.
>
> But the main problem with this is that it makes us try to understand a
> prefix arg that is BOTH zero and -1, and it leaves us wondering what
> "the integer" is that is tested against
> `eval-expression-print-maximum-character' when the prefix arg is zero.
>
> If "the integer" is just the numeric prefix arg then the <=
> `eval-expression-print-maximum-character' could be clear - but there
> should be no connection with the value being zero ("such a prefix arg").
> Just say: If zero then no truncation. If <= `eval...' then ___
> (whatever is meant by "character format" printing).
Thanks, I fixed the doc string on the emacs-26 branch to be both clear
and correct.
prev parent reply other threads:[~2018-07-06 9:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 20:15 bug#32064: 26; doc string of `eval-last-sexp' Drew Adams
2018-07-05 21:56 ` Drew Adams
2018-07-06 0:23 ` Noam Postavsky
2018-07-06 9:39 ` Eli Zaretskii
2018-07-06 11:47 ` Noam Postavsky
2018-07-06 17:55 ` Drew Adams
2018-07-06 9:37 ` Eli Zaretskii
2018-07-06 9:34 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y3eolncc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32064@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.